1782753 - Remove unused HandleScope from CheckPatternSyntaxImpl

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Frontend uses irregexp only to check the syntax, by irregexp::CheckPatternSyntax,
and most part of irregexp::Isolate is unnecessary.

To decouple JSContext from frontend, check-pattern-specific part of irregexp::Isolate needs to be factored out.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1782753 - Remove unused HandleScope from CheckPatternSyntaxImpl. r?iain!

CheckPatternSyntaxImpl shouldn't allocate any GC things, and
HandleScope shouldn't be necessary.

Depends on D153555

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1782753 - Part 2: Add js::irregexp::ParseIsolate and v8::internal::RuntimeIsolate. r?iain!

js::irregexp::ParseIsolate is base class which provides feature necessary for
CheckPatternSyntax.
This class definition is exposed to make it possible to be allocated on stack.

v8::internal::Isolate provides all methods, delegating to v8::internal::RuntimeIsolate for most of them.

v8::internal::RuntimeIsolate is previous v8::internal::Isolate that provides everything.

Isolate backed by ParseIsolate can be used only in CheckPatternSyntax.
Isolate backed by RuntimeIsolate can be used for all cases.

Depends on D153704

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1782753 - Part 3: Use js::irregexp::ParseIsolate in js::irregexp::CheckPatternSyntax. r?iain!

Depends on D153706

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1782753 - Part 4: Use js::irregexp::ParseIsolate instance in parser. r?iain!

Depends on D153707

Comment 5

[Tooru Fujisawa [:arai]]

Most part gets resolved by bug 1779849

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c144248852e3
Remove unused HandleScope from CheckPatternSyntaxImpl. r=iain

Comment 7

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/c144248852e3