Closed Bug 1782766 Opened 2 months ago Closed 2 months ago

Constraint the max height of the list of extensions in the unified extensions panel

Categories

(WebExtensions :: General, defect)

defect

Tracking

(firefox105 fixed)

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: willdurand, Assigned: willdurand)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

This looks like it has regressed but I don't see how/when.

STR:

  1. Enable the unified extensions feature
  2. Install ~15 extensions

Expected:

The panel shows most of the extensions and the list has a scrollbar. The "Manage extensions" button in the footer is always visible.

Actual:

There is no scrollbar on the list.

Pushed by wdurand@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d96c8b5946a
Constraint the max height of the list of extensions in the unified extensions panel. r=Itiel,desktop-theme-reviewers

Backed out changeset 5d96c8b5946a (bug 1782766) for causing browser-chrome failures in browser/components/extensions/test/browser/browser_unified_extensions_context_menu.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f2d229e996a93d99ac72c5a9e46f8ae4971d92b4

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_unified_extensions_context_menu.js | Test timed out - 
[task 2022-08-03T21:21:59.154Z] 21:21:59     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-08-03T21:21:59.155Z] 21:21:59     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_unified_extensions_context_menu.js | Extension left running at test shutdown -
Flags: needinfo?(wdurand)

I am not quite sure what's happening as we are only changing a few lines of CSS. Anyway, :rpl and I are trying to fix intermittent failures first (Bug 1782304 and Bug 1782138) because those errors in https://bugzilla.mozilla.org/show_bug.cgi?id=1782766#c3 are the same. We'll see if our fixes are enough to re-land the patch safely or if we need more work. Thanks!

Flags: needinfo?(wdurand)
Attachment #9288139 - Attachment description: Bug 1782766 - Constraint the max height of the list of extensions in the unified extensions panel. r?Itiel! → Bug 1782766 - Constraint the max height of the list of extensions in the unified extensions panel. r?Itiel!,rpl!
Pushed by wdurand@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a5574c97e29
Constraint the max height of the list of extensions in the unified extensions panel. r=Itiel,desktop-theme-reviewers,rpl
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.