Closed Bug 1782852 Opened 2 months ago Closed 2 months ago

Get rid of the legacy editor commands which are not used in the wild

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(3 files)

Starting from 92, we disabled them in Nightly channel (bug 1706266). And there is no regression reports, but according to the telemetry result (added in bug 1706268), some commands may still be used.

I think that we could try to disable them in early beta too. However, I don't think we should delete them immediately because they are used constantly in multiple beta releases.

The other commands are really rare and these counters have been stopped collecting the usage.

So we can delete them.

Summary: Get rid of the legacy editor commands which are not used in the wild → Disable the legacy editor commands which are not used in the wild

Ah, we should disable them in beta/release channel first.

Oops, they are already disabled in release channel. So, we should delete them. Sorry for the spam.

Summary: Disable the legacy editor commands which are not used in the wild → Get rid of the legacy editor commands which are not used in the wild

increaseFontSize, decreaseFontSize, gethtml, heading and readonly
commands were disabled for a year in all channels, but no regression reports
have been filed. Therefore, we can delete the commands and the telemetry
probes.

Note that cmd_getContents command which is the internal command of gethtml
is not used in comm-central too. Therefore, this patch deletes the command
handler, nsClipboardGetContentsCommand, and Command::GetHTML too.

Attachment #9288446 - Attachment description: Bug 1782852 - part 2: Enable Gecko specific commands which are enabled only in Nightly channel in Beta channel too r=smaug → Bug 1782852 - part 2: Disable Gecko specific commands which are disabled only in the Nightly channel in early beta too r=smaug
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/6c8bd45039f6
part 1: Get rid of unused editor commands in the wild r=smaug
https://hg.mozilla.org/integration/autoland/rev/99538761dfaf
part 2: Disable Gecko specific commands which are disabled only in the Nightly channel in early beta too r=smaug
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

I think you set the pref reversed. It should be enabled when @IS_NOT_EARLY_BETA_OR_EARLIER@ is true.

Flags: needinfo?(masayuki)

(In reply to Mathew Hodson from comment #7)

I think you set the pref reversed. It should be enabled when @IS_NOT_EARLY_BETA_OR_EARLIER@ is true.

Oh, right!

Status: RESOLVED → REOPENED
Flags: needinfo?(masayuki)
Resolution: FIXED → ---

This is my silly mistake. I set reverted value to the prefs and the expectation
of WPTs. We need to enable them in late beta and release and disable them in
early beta and nightly.

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/af94f567070c
part 3: Revert the pref value to enable legacy editor commands in late beta and release r=smaug
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED

(In reply to Mathew Hodson from comment #7)

I think you set the pref reversed. It should be enabled when @IS_NOT_EARLY_BETA_OR_EARLIER@ is true.

I forgot to say, thank you for pointing out it.

You need to log in before you can comment on or make changes to this bug.