1782852 - Get rid of the legacy editor commands which are not used in the wild

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Starting from 92, we disabled them in Nightly channel (bug 1706266). And there is no regression reports, but according to the telemetry result (added in bug 1706268), some commands may still be used.

• document.execCommand("contentReadonly")
• document.queryCommandSupported("insertBROnReturn") or document.queryCommandEnabled("insertBROnReturn")

I think that we could try to disable them in early beta too. However, I don't think we should delete them immediately because they are used constantly in multiple beta releases.

The other commands are really rare and these counters have been stopped collecting the usage.

• increateFontSize
• decreaseFontSize
• heading

So we can delete them.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, we should disable them in beta/release channel first.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oops, they are already disabled in release channel. So, we should delete them. Sorry for the spam.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1782852 - part 1: Get rid of unused editor commands in the wild r=smaug

increaseFontSize, decreaseFontSize, gethtml, heading and readonly
commands were disabled for a year in all channels, but no regression reports
have been filed. Therefore, we can delete the commands and the telemetry
probes.

Note that cmd_getContents command which is the internal command of gethtml
is not used in comm-central too. Therefore, this patch deletes the command
handler, nsClipboardGetContentsCommand, and Command::GetHTML too.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1782852 - part 2: Disable Gecko specific commands which are disabled only in the Nightly channel in early beta too r=smaug

This is a trial to get reports of breakage of web apps in the wild from beta
users. Currently we don't have any bug reports from Nightly users, but according
to the telemetry in Beta channel, there are some web apps using it (perhaps,
for feature detection or one of finger prints) because we get over 1k pings
per day.

contentReadOnly:
https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=True%2520percentage&cumulative=0&end_date=2022-07-25&include_spill=0&keys=!__none__!__none__&max_channel_version=beta%252F103&measure=USE_COUNTER2_DOCUMENTEXECCOMMANDCONTENTREADONLY_DOCUMENT&min_channel_version=beta%252F100&processType=*&product=Firefox&sanitize=0&sort_keys=submissions&start_date=2022-06-27&trim=0&use_submission_date=0

insertBROnReturn:
https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=True%2520percentage&cumulative=0&end_date=2022-07-25&include_spill=0&keys=!__none__!__none__&max_channel_version=beta%252F103&measure=USE_COUNTER2_DOCUMENTQUERYCOMMANDSUPPORTEDORENABLEDINSERTBRONRETURN_DOCUMENT&min_channel_version=beta%252F100&processType=*&product=Firefox&sanitize=0&sort_keys=submissions&start_date=2022-06-27&trim=0&use_submission_date=0

If we won't have any regression reports with this, perhaps, we could try to
roll out to disable these commands.

Depends on D153720

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c8bd45039f6
part 1: Get rid of unused editor commands in the wild r=smaug
https://hg.mozilla.org/integration/autoland/rev/99538761dfaf
part 2: Disable Gecko specific commands which are disabled only in the Nightly channel in early beta too r=smaug

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6c8bd45039f6
https://hg.mozilla.org/mozilla-central/rev/99538761dfaf

Comment 7

[Mathew Hodson]

I think you set the pref reversed. It should be enabled when @IS_NOT_EARLY_BETA_OR_EARLIER@ is true.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Mathew Hodson from comment #7)

I think you set the pref reversed. It should be enabled when @IS_NOT_EARLY_BETA_OR_EARLIER@ is true.

Oh, right!

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1782852 - part 3: Revert the pref value to enable legacy editor commands in late beta and release r=smaug

This is my silly mistake. I set reverted value to the prefs and the expectation
of WPTs. We need to enable them in late beta and release and disable them in
early beta and nightly.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af94f567070c
part 3: Revert the pref value to enable legacy editor commands in late beta and release r=smaug

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/af94f567070c

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Mathew Hodson from comment #7)

I think you set the pref reversed. It should be enabled when @IS_NOT_EARLY_BETA_OR_EARLIER@ is true.

I forgot to say, thank you for pointing out it.