1782991 - BrowserUsageTelemetry.jsm logs an error to the console every time I click in the search engine list in preferences (TypeError: node.getAttribute is not a function)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mark Banner (:standard8)]

STR

1. Open preferences and select the search pane.
2. Click anywhere in the Search shortcuts table, and monitor the browser console.

Actual Result

JavaScript error: resource:///modules/BrowserUsageTelemetry.jsm, line 832: TypeError: node.getAttribute is not a function

Expected Result

No errors.

I think this is a regression from bug 1757353. I'm going to put up a patch for it.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1782991 - Avoid an error in BrowserUsageTelemetry when clicking in the search shortcuts table in preferences. r?Gijs

This detects if we've got to the parent document and if so, exits early - we don't appear to collect clicks on the parent document, so no need to go further.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1757353

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01f1a7f0b385
Avoid an error in BrowserUsageTelemetry when clicking in the search shortcuts table in preferences. r=Gijs

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/01f1a7f0b385