1783045 - Implement Cookie Banner Clicking

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Tim Huang[:timhuang]]

The cookie banner clicking will be responsible for detecting if the cookie banner is present on the page and try to click either Reject All or Accept All button.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1783045 - Part 1: Add banner clicking rule into the CookieBannerRule. r?pbz!

This patch adds four fields into the nsICookieBannerRule that are used
for the banner clicking. It also updates the CookieBannerListService.jsm
to also import the click rule.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1783045 - Part 2: Implementing nsIClickRule and nsICookieBannerService.getClickRuleForDomain(). r?pbz!

This patch implements the nsIClickRule that represents the rule that we
need to do in the page in order to handle the cookie banner. We also
implments the nsICookieBannerService.getClickRuleForDoamin() that allows
the click rule to be acquired from the service for the given domain.

Depends on D154804

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1783045 - Part 3: Implementing CookieBanner JSWindowActor to handle the cookie banner. r?pbz!

The patch implements a CookieBanner JSWindowActor. The CookieBanner
actor will be created when the DOMContentLoaded event files, and try to
detect the cookie banner and click the button to handle it.

Depends on D154805

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1783045 - Part 4: Add tests for the banner auto clicking. r?pbz

Depends on D154806

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d23dc4db85cc
Part 1: Add banner clicking rule into the CookieBannerRule. r=pbz
https://hg.mozilla.org/integration/autoland/rev/07cc853ae0ec
Part 2: Implementing nsIClickRule and nsICookieBannerService.getClickRuleForDomain(). r=pbz
https://hg.mozilla.org/integration/autoland/rev/73d747392a6c
Part 3: Implementing CookieBanner JSWindowActor to handle the cookie banner. r=pbz
https://hg.mozilla.org/integration/autoland/rev/858bd17dff03
Part 4: Add tests for the banner auto clicking. r=pbz

Comment 6

[Atila Butkovits]

Backed out for causing xpcshell failures complaining about CookieBanner

Backout link: https://hg.mozilla.org/integration/autoland/rev/98400db7c4525da8aa8b66a562af1e0382d007ba

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=858bd17dff032308fae3a50df7dd6f9d41466d48&selectedTaskRun=B6pIxYKjSKu85RWeLtxgPw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=388190705&repo=autoland&lineNumber=7210

https://treeherder.mozilla.org/logviewer?job_id=388192173&repo=autoland&lineNumber=4388

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc72e8315883
Part 1: Add banner clicking rule into the CookieBannerRule. r=pbz
https://hg.mozilla.org/integration/autoland/rev/325242371824
Part 2: Implementing nsIClickRule and nsICookieBannerService.getClickRuleForDomain(). r=pbz
https://hg.mozilla.org/integration/autoland/rev/99e43adb64de
Part 3: Implementing CookieBanner JSWindowActor to handle the cookie banner. r=pbz
https://hg.mozilla.org/integration/autoland/rev/41410adb6177
Part 4: Add tests for the banner auto clicking. r=pbz

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bc72e8315883
https://hg.mozilla.org/mozilla-central/rev/325242371824
https://hg.mozilla.org/mozilla-central/rev/99e43adb64de
https://hg.mozilla.org/mozilla-central/rev/41410adb6177