1783093 - RemoteImagesTestUtils clears RS Server pref instead of resetting its value

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P1)

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1783093 - Don't call clearUserPref for the RS server pref in RemoteImages tests r?thecount

If we clear the pref, we end up clearing the user-branch value set for tests
and end up with default branch value, which will point to the Remote Settings
server used in production.

Instead, we store the original value when we would reset it so that we have end
up with the pref set to the test value instead of the real value.

Comment 2

[Daniel Holbert [:dholbert]]

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a32a6a64c8d
Don't call clearUserPref for the RS server pref in RemoteImages tests r=thecount

Comment 4

[Daniel Holbert [:dholbert]]

BTW, I filed bug 1783248 to catch these sorts of issues in the future (as part of test-verify runs).

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4a32a6a64c8d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/0f9ee6312fe2