1783274 - Page background is grey, design file page background is white

Status: RESOLVED WONTFIX

(Firefox :: Firefox View, defect)

Description

[Josh Berman]

Attachment: Screen Shot 2022-08-04 at 2.49.24 PM.png

Actual: Page body background is grey
Expected: Page body background is white

Comment 1

[Sarah Clements [:sclements]]

Well, it's using ntp_background or --newtab-background-color variable, same as the new tab page. If we change it to --newtab-background-secondary, the background won't match the figma when the colorway themes are applied.

Comment 2

[Dão Gottwald [:dao]]

Yeah, this is a consequence of adopting new tab colors and being consistent about it (i.e. we need to do that for all themes, not just colorways). ntp_card_background wouldn't be the right color to use semantically and would cause other issues as Sarah pointed out.

Comment 3

[:Gijs (he/him)]

Did we deliberately change the decision here, as Firefox View is now using a white background when using the light default theme?

I don't really mind either way tbh... just trying to clarify what happened.

Comment 4

[Sarah Clements [:sclements]]

(In reply to :Gijs (he/him) from comment #3)

Did we deliberately change the decision here, as Firefox View is now using a white background when using the light default theme?

I don't really mind either way tbh... just trying to clarify what happened.

Its using the --in-content-background-color as a fallback when the system theme is selected (light theme shows the new tab background color). I think the color was selected during the review process in D151043 just because we were previously using it. I can't see why we couldn't set it to the same color as new tab page for consistency.