1783373 - Download panel will not appear in private window when taking a screenshot using devtools

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[6k64x4ma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:104.0) Gecko/20100101 Firefox/104.0

Steps to reproduce:

1. Open a private window and a non-private window.
2. Take a screenshot using Inspector or Responsive Design Mode on the private window.
3. Close the non-private window and take another screenshot.

Actual results:

1. If there is a non-private window, the download panel will appear in the non-private window.
2. If there are no non-private windows, the download panel will not be displayed.

Expected results:

The download panel should be displayed in a private window in both cases.

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for filing, Nicolas will take a look

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

This is where we trigger the Download panel behavior:

https://searchfox.org/mozilla-central/rev/6ec440e105c2b75d5cae9d34f957a2f85a106d54/devtools/client/shared/screenshot.js#363-371

const download = await Downloads.createDownload({
  source: sourceURI,
  target: targetFile,
});
const list = await Downloads.getList(Downloads.ALL);
// add the download to the download list in the Downloads list in the Browser UI
list.add(download);
// Await successful completion of the save via the download manager
await download.start();

It looks like Downloads.createDownload take a isPrivate param (toolkit/components/downloads/Downloads.jsm#81-82,107-113 ) which we could pass from DevTools code

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1783373 - [devtools] Pass isPrivate property to Downloads.createDownload. r=jdescottes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/176ca1d8bfc6
[devtools] Pass isPrivate property to Downloads.createDownload. r=jdescottes.

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/176ca1d8bfc6