1783402 - Make result of getter methods of `EditorDOMPointBase` and `SplitRangeOffFromNodeResult` templated

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It's not reasonable to add getter methods such as Get*AsElement(), Get*AsText()... Instead, they can be Get*As<Element>(), Get*As<Text>(), etc.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1783402 - part 1: Make result of the getter methods of `SplitRangeOffFromNodeResult` templated r=m_kato!

We'll need the version to return dom::Text* in coming patches for bug 1735608.
For avoiding the class to have a lot of getters, we should make result of the
getters templated.

Depends on D153838

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1783402 - part 2: Make result of safe getter methods of `EditorDOMPointBase` templated r=m_kato!

Similar to the previous patch, and for consistency between editor helper
classes, we should make result of getter methods of EditorDOMPointBase too.

Depends on D153840

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1783402 - part 3: Make result of unsafe getter methods of `EditorDOMPointBase` templated r=m_kato!

Depends on D153841

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/378289e8030b
part 1: Make result of the getter methods of `SplitRangeOffFromNodeResult` templated r=m_kato
https://hg.mozilla.org/integration/autoland/rev/22de73c7fb44
part 2: Make result of safe getter methods of `EditorDOMPointBase` templated r=m_kato
https://hg.mozilla.org/integration/autoland/rev/18bbc1d50e89
part 3: Make result of unsafe getter methods of `EditorDOMPointBase` templated r=m_kato

Comment 5

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/378289e8030b
https://hg.mozilla.org/mozilla-central/rev/22de73c7fb44
https://hg.mozilla.org/mozilla-central/rev/18bbc1d50e89