1783422 - Enable additional ESLint rules relevant for selfhosted code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1783422 - Part 1: Move self-hosted code specific ESLint rules into the "overrides" section. r=tcampbell!

These rules should only be applied to self-hosted code, but not for example to
the .eslintrc.js file itself.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1783422 - Part 2: Enable "no-void" ESLint rule. r=tcampbell!

Enable this rule to avoid regressing bug 1780517 over time.

Depends on D153848

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1783422 - Part 3: Enable "eqeqeq" ESLint rule. r=tcampbell!

We have to be extra careful not to use x == null, otherwise we might introduce
spec compliance bugs. For example the two changes in "Tuple.js" are actually bugs
uncovered by this rule.

Depends on D153849

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1783422 - Part 4: Enable "strict" ESLint rule. r=tcampbell!

Self-hosted code is implicitly strict mode. Any extra strict mode directive
is probably an error.

Depends on D153850

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1783422 - Part 5: Enable "no-restricted-syntax" ESLint rule. r=tcampbell!

Report an error for disallowed syntax. Either the parser or the byte code
emitter will assert when restricted syntax is encountered, but this rule
allows to reject invalid syntax directly when linting.

Depends on D153851

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8784c2316a4d
Part 1: Move self-hosted code specific ESLint rules into the "overrides" section. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/f1222ec4d3e2
Part 2: Enable "no-void" ESLint rule. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1dfe7568c39e
Part 3: Enable "eqeqeq" ESLint rule. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e3863be25196
Part 4: Enable "strict" ESLint rule. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7d338be64b49
Part 5: Enable "no-restricted-syntax" ESLint rule. r=tcampbell

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8784c2316a4d
https://hg.mozilla.org/mozilla-central/rev/f1222ec4d3e2
https://hg.mozilla.org/mozilla-central/rev/1dfe7568c39e
https://hg.mozilla.org/mozilla-central/rev/e3863be25196
https://hg.mozilla.org/mozilla-central/rev/7d338be64b49