1783442 - WebExtensionPolicy case missmatch with hostname is possible

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P3)

Description

[Shane Caraveo (:mixedpuppy)]

WebExtensionPolicy accepts any char case for mozHostname, which in practice doesn't matter since we pass in lowercased uuid's for this. However, a test that passes an upper case uuid can have unexpected failures. The following will fail. This was discovered while working on a followup fix in D153865.

const uuid3 = "56652231-D7E2-45D1-BDBD-BD3BFF80927E";
  let policy3 = new WebExtensionPolicy({
    id: "some@id",
    mozExtensionHostname: uuid3,
    baseURL,
    localizeCallback() {},
    allowedOrigins: new MatchPatternSet([]),
    permissions: ["<all_urls>"],
  });
  policy3.active = true;
  equal(
    WebExtensionPolicy.getByHostname(uuid3),
    policy3,
    "Hostname lookup should match policy"
  );

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1783442 Fix cases where case sensitivy matters in WebExtensionPolicy

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e4ba71601a2
Fix cases where case sensitivy matters in WebExtensionPolicy r=zombie

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1e4ba71601a2