1783567 - Instagram and Twitter broken if network.http.http3.enable=false: Can't like posts ("Something went wrong. Please try again." after a few seconds) or access activity menu (endless loading circle)

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Darkspirit]

mozregression --good 2022-08-01 --bad 2022-08-06 -a https://www.instagram.com --pref privacy.firstparty.isolate:true network.http.http3.enable:false

18:53.74 INFO: Last good revision: 8ca492989a69cafcf8509abec8fa0eab728d9085
18:53.74 INFO: First bad revision: efd9f190d5062d057ebe3a6adeb6ba235461cb62
18:53.74 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8ca492989a69cafcf8509abec8fa0eab728d9085&tochange=efd9f190d5062d057ebe3a6adeb6ba235461cb62

efd9f190d5062d057ebe3a6adeb6ba235461cb62 Kershaw Chang — Bug 1772201 - Fix intermittent test failure, r=necko-reviewers,dragana
7ac049634840c925282c260ccb7d45368385e731 Kershaw Chang — Bug 1772201 - Remove TLSFilterTransaction, r=necko-reviewers,dragana
e92fb7d8e9845badd617ba1e8caf19544a436f35 Kershaw Chang — Bug 1772201 - Improve the closing of TLSTransportLayer, r=necko-reviewers,dragana
21b272c5afe5092b7502dc1766f6a8d55648702e Kershaw Chang — Bug 1772201 - Support plain http over Http/2 proxy, r=necko-reviewers,dragana
8f0ca2710ee19b23e25716561f53d5a67859efbf Kershaw Chang — Bug 1772201 - Introduce TLSTransportLayer, r=necko-reviewers,dragana
e59ce1d680da8adbbad2a5009fb82b2a9bcf42ec Dragana Damjanovic — Bug 1772205 - Add more test for failures: r=necko-reviewers,kershaw
58c3061e18da562b1c453ee4025c0526dc0edb95 Dragana Damjanovic — Bug 1772205 - Improve closing of Http2StreamTunnel. r=necko-reviewers,kershaw
4335ced4d484b1ba0d15b7c6b6567138ffbce8b8 Dragana Damjanovic — Bug 1772205 - Implement a special version of Http2Stream that will be used for tunneling. r=necko-reviewers,kershaw

last good:
mozregression --repo autoland --launch 8ca492989a69cafcf8509abec8fa0eab728d9085 -a https://www.instagram.com --pref network.http.http3.enable:false

first bad:
mozregression --repo autoland --launch efd9f190d5062d057ebe3a6adeb6ba235461cb62 -a https://www.instagram.com --pref network.http.http3.enable:false

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1783567 - Correct the if statement, r=#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1783567 - test case, r=#necko

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

(Just for anyone searching about Twitter issue, since bug 1783553 is marked as dupe)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba0a724b0a79
Correct the if statement, r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c8782cefb8a3
test case, r=necko-reviewers,dragana

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ba0a724b0a79
https://hg.mozilla.org/mozilla-central/rev/c8782cefb8a3

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba0a724b0a79
Correct the if statement, r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c8782cefb8a3
test case, r=necko-reviewers,dragana

== Change summary for alert #35077 (as of Wed, 10 Aug 2022 16:32:42 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
17%	imgur loadtime	windows10-64-shippable-qr	cold fission webrender	2,113.27 -> 1,756.58

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35077