1783570 - Checking for pkg-config in embedder build broken on macOS

Status: RESOLVED DUPLICATE of bug 1776255

(Firefox Build System :: General, defect)

Description

[Philip Chimento [:ptomato]]

The fix for Bug 513617 broke SpiderMonkey embedder builds on macOS. check_prog() is never executed for pkg-config when target.os is "OSX", so pkg_config is always None and subsequent usages of things like pkg_check_modules() which depend on the pkg_config target will fail with the following message:

ERROR: *** The pkg-config script could not be found. Make sure it is
*** in your path, or set the PKG_CONFIG environment variable
*** to the full path to pkg-config.

In addition, this error is misleading, because it occurs even when the pkg-config binary is in the path and the PKG_CONFIG environment variable is set.

Comment 1

[Philip Chimento [:ptomato]]

Attachment: Bug 1783570 - Check for pkg-config on macOS. r?glandium

SpiderMonkey embedder builds require checking for pkg-config. Without
this, the configure step will fail with a misleading error message about
pkg-config not existing.

Comment 2

[Philip Chimento [:ptomato]]

I'm guessing this patch is not quite what you want, but this is what I'm using downstream for now and I'd love to know how to adapt it to get it upstream.