1783573 - nsIMsgAsyncPrompter.queueAsyncAuthPrompt() prompts should auto-cancel upon shutdown?

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, task)

Description

[Ben Campbell]

(Following on from Bug 1629669)

I don't think async prompts are cancelled when shutdown occurs.

Example:
The IMAP protocol thread calls nsImapIncomingServer::AsyncGetPassword() on the main thread to get a password. If the password is not set, this means popping up an async password prompt for the user (the IMAP protocol object is passed in as the listener - it implements nsIMsgAsyncPromptListener.

If shutdown occurs while the prompt is up, experience from Bug 1629669 suggests the listener is never informed. It should be!
Probably just by calling onPromptCanceled() on the listener.

For Bug 1629669 the proposed fix is to add an explicit check for shutdown, but really, the check for NS_MSG_PASSWORD_PROMPT_CANCELLED (set by the onPromptCanceled() handler) should be enough to break out of the loop.

Comment 1

[Worcester12345]

(In reply to Ben Campbell from comment #0)

(Following on from Bug 1629669)

I don't think async prompts are cancelled when shutdown occurs.
...
For Bug 1629669 the proposed fix is to add an explicit check for shutdown, but really, the check for NS_MSG_PASSWORD_PROMPT_CANCELLED (set by the onPromptCanceled() handler) should be enough to break out of the loop.

That is now the "implemented fix", correct? So, IS the NS_MSG_PASSWORD_PROMPT_CANCELLED (set by the onPromptCanceled() handler) enough to break out of the loop, as you inquired above? If so, is there a patch for that?

Comment 2

[Wayne Mery (:wsmwk)]

This has potential to kill or significantly reduce our #1 crash https://crash-stats.mozilla.org/topcrashers/?product=Thunderbird&version=128.5.0esr&_facets_size=200&_report_type=any

Comment 3

[Toby Pilling [:tobyp]]

Hey Geoff, could your fix for bug 1934491 be used to address this? (#1 crash)

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Toby Pilling [:tobyp] from comment #3)

Hey Geoff, could your fix for bug 1934491 be used to address this? (#1 crash)

Footnote, bug 1934491 had two regressions reported.

Comment 5

[Magnus Melin [:mkmelin]]

(In reply to Ben Campbell from comment #0)

I don't think async prompts are cancelled when shutdown occurs.

Seems they are though, at least now.
Was going to try have an "quit-application" observer while doing _promiseAuthPrompt() in run(). But, if I quit (from another window), that promise already gets resolved. So nothing to do I think.
But I'll attach the modernization I did while looking at this.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1783573 - Modernize MsgAsyncPrompter.sys.mjs. r=BenC

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1fb337050145
Modernize MsgAsyncPrompter.sys.mjs. r=BenC

Comment 8

[Wayne Mery (:wsmwk)]

status-thunderbird145: --- → fixed
Target Milestone: --- → 146 Branch

Magnus, did you intend status-thunderbird145 to be wontfix?

Comment 9

[Magnus Melin [:mkmelin]]

Yes, ended up with just cleanup in this bug. I could not reproduce the original issue.

Comment 10

[Wayne Mery (:wsmwk)]

No apparent change in beta crash rate, at least up to 146.0b2