Closed Bug 1783602 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 35374 - Fetch: Add tests for AbortSignal's abort reason

Categories

(Core :: DOM: Networking, task, P4)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35374 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35374
Details from upstream follow.

Nidhi Jaju <nidhijaju@chromium.org> wrote:

Fetch: Add tests for AbortSignal's abort reason

This PR adds test cases to check the functionality of AbortSignal's abort reason when aborting fetch.

See https://github.com/whatwg/fetch/pull/1343 for accompanying spec changes.

Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 10 subtests

Status Summary

Firefox

OK : 4
PASS : 195
FAIL : 17
TIMEOUT: 2
NOTRUN : 1

Chrome

OK : 4
PASS : 199
FAIL : 13
TIMEOUT: 2
NOTRUN : 1

Safari

OK : 4
PASS : 199
FAIL : 13
TIMEOUT: 2
NOTRUN : 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /fetch/api/abort/general.any.sharedworker.html [wpt.fyi]
    • Aborting rejects with abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Signal on request object should also have abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Stream will not error if body is empty. It's closed with an empty queue before it errors.: FAIL (Chrome: PASS, Safari: PASS)
    • Readable stream synchronously cancels with AbortError if aborted before reading: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/api/abort/general.any.worker.html [wpt.fyi]
    • Aborting rejects with abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Signal on request object should also have abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Stream will not error if body is empty. It's closed with an empty queue before it errors.: FAIL (Chrome: PASS, Safari: PASS)
    • Readable stream synchronously cancels with AbortError if aborted before reading: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/api/abort/general.any.serviceworker.html [wpt.fyi]
    • Aborting rejects with abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Signal on request object should also have abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Stream will not error if body is empty. It's closed with an empty queue before it errors.: FAIL (Chrome: PASS, Safari: PASS)
    • Readable stream synchronously cancels with AbortError if aborted before reading: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/api/abort/general.any.html [wpt.fyi]
    • Aborting rejects with abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Signal on request object should also have abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Stream will not error if body is empty. It's closed with an empty queue before it errors.: FAIL (Chrome: PASS, Safari: PASS)
    • Readable stream synchronously cancels with AbortError if aborted before reading: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/api/abort/serviceworker-intercepted.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • fetch() rejects with abort reason: FAIL (Chrome: FAIL, Safari: FAIL)
    • Service Worker can observe the fetch abort and associated abort reason: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • Abort reason serialization happens on abort: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da19a04e021c [wpt PR 35374] - Fetch: Add tests for AbortSignal's abort reason, a=testonly https://hg.mozilla.org/integration/autoland/rev/420e639355a6 [wpt PR 35374] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/da19a04e021c
https://hg.mozilla.org/mozilla-central/rev/420e639355a6

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.