Open Bug 1783613 Opened 2 years ago

Node actor form do not consistently set all properties

Categories

(DevTools :: Inspector, task)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

Details

Spotted while working on Bug 1783606, some flags from the node actor (isDocumentElement, useChildTargetToFetchChildren) are not consistently returned. They are only returned when they are true. In the false case, the value we see on the client is actually undefined.

This can lead to unexpected issues when you compare the value to an actual boolean (undefined is different from false). This lead to false positives and unnecessary updates in Bug 1783606.

I guess there is an argument for making forms as small as possible though, and avoid sending unnecessary properties, but we should have a way to set good defaults on the client maybe.

You need to log in before you can comment on or make changes to this bug.