1783738 - Support decorator expressions in Parser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Dan Minor [:dminor]]

A first step to implementing the decorators proposal is to add support in the parser for decorator expressions.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1783738 - Add decorators to build configuration; r=mgaudet!

This is necessary to be able to skip tests when we haven't built with support
for decorators.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1783738 - Make 'accessor' a contextual keyword; r=mgaudet!

This should be a contextual keyword to avoid conflicting with existing
uses of the identifier. It's inserted out of alphabetical order to
avoid having to make the range conditional on whether ENABLE_DECORATORS
is defined.

Depends on D154187

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1783738 - Support decorator expressions on methods and fields; r=mgaudet!

This adds support for decorator expressions inside classes for methods
and fields. Support for class declarations and expressions is added in
the next commit.

Depends on D154188

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1783738 - Support decorator expressions on classes; r=mgaudet!

This adds decorator support to class definitions and expressions

Depends on D154189

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ca5e3471c04
Add decorators to build configuration; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/9d7f488a2cd9
Make 'accessor' a contextual keyword; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/6cd01666a991
Support decorator expressions on methods and fields; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a10f3d51daad
Support decorator expressions on classes; r=mgaudet

Comment 6

[Cristian Tuns]

Backed out for causing reftest failures with getBuildConfiguration

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST ERROR | EXCEPTION: ReferenceError: getBuildConfiguration is not defined

Comment 7

[Dan Minor [:dminor]]

I'm going to move the new tests to jit-test, it looks like getBuildConfiguration is normally only used with them, although this did pass locally and on some try runs 🤔

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1783738 - Move decorator tests to jit-test; r=mgaudet!

This moves the decorator tests to jit-test because getBuildConfiguration()
doesn't seem to be consistently available while running jstests.
This also fixes two tests that were not passing with decorators enabled.

Depends on D154190

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64f08575ffaa
Add decorators to build configuration; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/28f32492d905
Make 'accessor' a contextual keyword; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/9cfb9c8223e2
Support decorator expressions on methods and fields; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/b985565ad43a
Support decorator expressions on classes; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/6b7c23368488
Move decorator tests to jit-test; r=mgaudet

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/64f08575ffaa
https://hg.mozilla.org/mozilla-central/rev/28f32492d905
https://hg.mozilla.org/mozilla-central/rev/9cfb9c8223e2
https://hg.mozilla.org/mozilla-central/rev/b985565ad43a
https://hg.mozilla.org/mozilla-central/rev/6b7c23368488