1783746 - [wpt-sync] Sync PR 35387 - Move focus-navigation tests to WPT

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35387 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35387
Details from upstream follow.

Di Zhang <[e-mail]> wrote:

Move focus-navigation tests to WPT

The current state of test_driver.send_keys and content_shell doesn't
allow focus navigation tests to be upstreamed to WPT. For example,
we can't do sequential focus navigation [1].

The current plan is to copy the existing focus-navigation tests to WPT
at external/wpt/shadow-dom/focus-navigation/ and keep the content_shell
tests at shadow-dom/focus-navigation/ for test coverage.

In the future, once [1] is resolved and we can run WPT test, we can remove
the duplicated tests that depends on the content_shell.

[1] https://github.com/whatwg/html/issues/4151

Change-Id: Ib4232494162e19110dfb785034712d56d3ff9491
Bug: 769673
Reviewed-on: https://chromium-review.googlesource.com/3817589
WPT-Export-Revision: a90809446ec9b4dc38f8ea4ad6b90adb26f7227c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb1df19122b1ac45174fd09cc000474e0a56d4e8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 21 tests and 2 subtests

Status Summary

Firefox

OK : 20
PASS : 42
FAIL : 1
TIMEOUT: 2
NOTRUN : 1

Chrome

OK : 21
PASS : 45

Safari

OK : 13
PASS : 19
FAIL : 4
TIMEOUT: 16
NOTRUN : 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /shadow-dom/focus-navigation/focus-with-negative-index.html [wpt.fyi]
  • This is a regression test: After focusing negative tabindex-ed elements, focus moves in tree order.: FAIL

New Tests That Don't Pass

• /shadow-dom/focus/focus-shadowhost-display-none.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • when shadow host itself is focused, it should match display:none, lose focus then becomes display:block again.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
  • when shadow host with delegatesFocus=true has focused element inside the shadow, it should also match display:none, then lose focus and become display:block again.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
• /shadow-dom/focus-navigation/focus-with-negative-index.html [wpt.fyi]
  • This is a regression test: After focusing negative tabindex-ed elements, focus moves in tree order.: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf3dd3e92d27
[wpt PR 35387] - Move focus-navigation tests to WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5628ca02fe31
[wpt PR 35387] - Update wpt metadata, a=testonly

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/cf3dd3e92d27
https://hg.mozilla.org/mozilla-central/rev/5628ca02fe31