1783784 - [rust 1.63] error: expected one of `!` or `::`, found keyword `mod`

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Mike Hommey [:glandium]]

[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -  error: expected one of `!` or `::`, found keyword `mod`
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -     --> /builds/worker/checkouts/gecko/third_party/rust/packed_simd_2/src/lib.rs:347:7
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -      |
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -  347 | crate mod llvm {
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -      |       ^^^ expected one of `!` or `::`
[task 2022-08-09T00:56:41.881Z] 00:56:41     INFO -  error: could not compile `packed_simd_2` due to previous error

This is fixed in upstream packed_simd 0.3.8. See https://github.com/hsivonen/packed_simd/pull/7

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1783784 - Update packed_simd_2 to 0.3.8.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure with rust 1.63
• User impact if declined: Build failure with rust 1.63
• Fix Landed on Version: 105
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No functional change to the crate that is updated.

Beta/Release Uplift Approval Request

• User impact if declined: Build failure with rust 1.63
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No functional change to the crate that is updated.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fac963c3bc00
Update packed_simd_2 to 0.3.8. r=hsivonen,supply-chain-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fac963c3bc00

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

Approved for 104.0b9

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c37c77a20f96

Comment 7

[tt_1]

do you have any plans to fix this for esr91 branch?

It seemingly ships packed_simd instead of packed_simd_2, so no easy backporting here.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

No, ESR91 is nearly at EOL at this point (91.13esr shipping next week is the last planned release).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

Approved for 102.3esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

This needs a more involved patch for ESR102 due to some other dependencies which need updating.

Comment 11

[Mike Hommey [:glandium]]

Patch updated.

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: See comment 2.
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

Approved for 102.3esr. Thanks for the fix-up.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/4598f299a274