Closed Bug 1783784 Opened 2 months ago Closed 2 months ago

[rust 1.63] error: expected one of `!` or `::`, found keyword `mod`

Categories

(Core :: Internationalization, defect)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox-esr102 --- fixed
firefox104 --- fixed
firefox105 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -  error: expected one of `!` or `::`, found keyword `mod`
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -     --> /builds/worker/checkouts/gecko/third_party/rust/packed_simd_2/src/lib.rs:347:7
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -      |
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -  347 | crate mod llvm {
[task 2022-08-09T00:56:41.880Z] 00:56:41     INFO -      |       ^^^ expected one of `!` or `::`
[task 2022-08-09T00:56:41.881Z] 00:56:41     INFO -  error: could not compile `packed_simd_2` due to previous error

This is fixed in upstream packed_simd 0.3.8. See https://github.com/hsivonen/packed_simd/pull/7

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure with rust 1.63
  • User impact if declined: Build failure with rust 1.63
  • Fix Landed on Version: 105
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No functional change to the crate that is updated.

Beta/Release Uplift Approval Request

  • User impact if declined: Build failure with rust 1.63
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No functional change to the crate that is updated.
  • String changes made/needed: N/A
  • Is Android affected?: No
Attachment #9288984 - Flags: approval-mozilla-esr102?
Attachment #9288984 - Flags: approval-mozilla-beta?
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/fac963c3bc00
Update packed_simd_2 to 0.3.8. r=hsivonen,supply-chain-reviewers
Blocks: 1783985
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

Approved for 104.0b9

Attachment #9288984 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

do you have any plans to fix this for esr91 branch?

It seemingly ships packed_simd instead of packed_simd_2, so no easy backporting here.

No, ESR91 is nearly at EOL at this point (91.13esr shipping next week is the last planned release).

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

Approved for 102.3esr.

Attachment #9288984 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

This needs a more involved patch for ESR102 due to some other dependencies which need updating.

Flags: needinfo?(mh+mozilla)
Attachment #9288984 - Flags: approval-mozilla-esr102+

Patch updated.

Flags: needinfo?(mh+mozilla)

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: See comment 2.
  • User impact if declined:
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
Attachment #9288984 - Flags: approval-mozilla-esr102?

Comment on attachment 9288984 [details]
Bug 1783784 - Update packed_simd_2 to 0.3.8.

Approved for 102.3esr. Thanks for the fix-up.

Attachment #9288984 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+
You need to log in before you can comment on or make changes to this bug.