Closed Bug 1783821 Opened 2 months ago Closed 1 month ago

Convert Launcher JSM to an ES Module

Categories

(DevTools :: Framework, task)

task

Tracking

(firefox106 fixed)

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: [esmification-timeline])

Attachments

(3 files)

Let's try to convert one DevTools JSM to a system ES Module.

Launcher.jsm, which is the module to open a Browser Toolbox is a good starting point as it should be mostly used by DevTools codebase.
https://searchfox.org/mozilla-central/search?q=%2FLauncher.jsm&path=&case=false&regexp=false

This is the result of:
$ ./mach esmify devtools/client/framework/browser-toolbox/Launcher.jsm

This is the result of:
$ ./mach esmify --imports . --prefix=devtools/client/framework/browser-toolbox

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

In md files and code comments and mostly from common js files.

I'm moving away from require to load sys.mjs files so that we are closer
to what we do in mozilla-central.

Blocks: 1525652
Blocks: 1788032
Whiteboard: [esmification-timeline]
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f1c8b21039c
[devtools] Convert Launcher JSM to an ES Module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/7c6d06d2adaa
[devtools] Load Launcher.sys.mjs via ChromeUtils.importESModule. r=perftest-reviewers,bomsy,arai,sparky
https://hg.mozilla.org/integration/autoland/rev/1be11ab96e3f
[devtools] Manual rewrites r=bomsy
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f5e630ff3658
Port bug 1783821 - Convert Launcher JSM to an ES Module. rs=bustage-fix DONTBUILD
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d8e8f046f20c
Port bug 1783821 (take 2) - Convert Launcher JSM to an ES Module. rs=bustage-fix DONTBUILD
You need to log in before you can comment on or make changes to this bug.