1783821 - Convert Launcher JSM to an ES Module

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Let's try to convert one DevTools JSM to a system ES Module.

Launcher.jsm, which is the module to open a Browser Toolbox is a good starting point as it should be mostly used by DevTools codebase.
https://searchfox.org/mozilla-central/search?q=%2FLauncher.jsm&path=&case=false&regexp=false

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1783821 - [devtools] Convert Launcher JSM to an ES Module.

This is the result of:
$ ./mach esmify devtools/client/framework/browser-toolbox/Launcher.jsm

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1783821 - [devtools] Load Launcher.sys.mjs via ChromeUtils.importESModule.

This is the result of:
$ ./mach esmify --imports . --prefix=devtools/client/framework/browser-toolbox

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1783821 - [devtools] Manual rewrites

In md files and code comments and mostly from common js files.

I'm moving away from require to load sys.mjs files so that we are closer
to what we do in mozilla-central.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f1c8b21039c
[devtools] Convert Launcher JSM to an ES Module. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/7c6d06d2adaa
[devtools] Load Launcher.sys.mjs via ChromeUtils.importESModule. r=perftest-reviewers,bomsy,arai,sparky
https://hg.mozilla.org/integration/autoland/rev/1be11ab96e3f
[devtools] Manual rewrites r=bomsy

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5f1c8b21039c
https://hg.mozilla.org/mozilla-central/rev/7c6d06d2adaa
https://hg.mozilla.org/mozilla-central/rev/1be11ab96e3f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f5e630ff3658
Port bug 1783821 - Convert Launcher JSM to an ES Module. rs=bustage-fix DONTBUILD

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d8e8f046f20c
Port bug 1783821 (take 2) - Convert Launcher JSM to an ES Module. rs=bustage-fix DONTBUILD