178383 - product/component query conditions appear twice

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When you run a query for product=foo OR product=bar, the query conditions appear
twice in the SQL query.

Comment 1

[Bradley Baetz (:bbaetz)]

There are actually two separate bugs here:

    if ($params->param('product')) {
        push(@supptables, "products products_");
        push(@wherepart, "products_.id = bugs.product_id");
        push(@specialchart, ["products_.name", "anyexact",
                             join(',',$params->param('product'))]);
    }

we can drop the @wherepart push, since the specialchart stuff will set that up
below (actually, it does |bugs.product_id = products_.id|, ie the other way
arround. Thats just cosmetic)

The other bug is that the (products_.name = "FOO") stuff is duplicated. Off the
top of my head, I'm not sure why that happens.

Comment 2

[Bradley Baetz (:bbaetz)]

-> me, with a patch

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: fix

Originally, I added that code to handle product searches, then I had to modify
the main query stuff to handle boolean charts, and forgot to take the original
change out.

trivial, myk has said r=myk on irc earlier

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 105674 [details] [diff] [review]
fix

myk said r=myk while bmo was down

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 105674 [details] [diff] [review]
fix

requesting a=

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 105674 [details] [diff] [review]
fix

r= justdave

Comment 7

[Bradley Baetz (:bbaetz)]

Checked in