1783933 - Avoid sContentParents assertion

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Andrew McCreight [:mccr8]]

As seen in bug 1745864, many kinds of leaks will cause us to not clean up ContentParents. This in turn means that sContentParents isn't empty when we shut down, which means we hit an assertion. This in effect causes leaks to get turned into a single generic assertion, which hurts distinguishing different leaks.

In bug 1661862, I wrote a little wrapper class that simply cleans up a static linked list when destroyed, rather than asserting. I'll do the same here.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1783933, part 2 - Use StaticAutoPtr in ContentParent.

This keeps us from asserting when a ContentParent leaks, in
order to keep different leaks from getting bucketed together
on TreeHerder.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1783933, part 1 - Remove ContentParent::sPrivateContent.

This static variable used to be set in a method called RecvPrivateDocShellsExist,
but it is now always null.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/940d75dffee4
part 1 - Remove ContentParent::sPrivateContent. r=nika
https://hg.mozilla.org/integration/autoland/rev/3b38f7a8b170
part 2 - Use StaticAutoPtr in ContentParent. r=nika

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/940d75dffee4
https://hg.mozilla.org/mozilla-central/rev/3b38f7a8b170