1783984 - `ac_add_options --enable-warnings-as-errors` doesn't work locally

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Kelsey Gilbert [:jgilbert]]

$ cat .mozconfig
ac_add_options --disable-debug
ac_add_options --disable-optimize

ac_add_options --enable-debug
#ac_add_options --enable-optimize

ac_add_options --enable-warnings-as-errors


[01:12:26] $? -> 0

Comment 1

[Mike Hommey [:glandium]]

if grep WARNINGS_AS_ERRORS obj*/config.status shows 'WARNINGS_AS_ERRORS': '-Werror',, then it works as it's supposed to.

Comment 2

[Kelsey Gilbert [:jgilbert]]

$ grep -nrE WARNINGS_AS_ERRORS obj-x86_64-pc-mingw32/config.status
710: 'WARNINGS_AS_ERRORS': '-Werror',

Please tell me more about how this is working as intended, because it doesn't feel very useful to me, so there must be reasons!

Comment 3

[Kelsey Gilbert [:jgilbert]]

Specifically, I ran into this most recently here: https://bugzilla.mozilla.org/show_bug.cgi?id=1779355
That builds cleanly on Windows for me with that mozconfig, but fails on CI, leading to backout.

Comment 4

[Mike Hommey [:glandium]]

Closing per discussion on Matrix ("Looks like this is a false alarm! Sorry, and thanks for the extra pairs of eyes!")