Closed Bug 1784007 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35415 - Fix flaky wpt test: css/selectors/invalidation/target-pseudo-in-has.html

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35415 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35415
Details from upstream follow.

Byungwoo Lee <blee@igalia.com> wrote:

Fix flaky wpt test: css/selectors/invalidation/target-pseudo-in-has.html

Remove assertions after inserting #fragment2 to fix flaky result.

The removed assertions try to check whether the :target element is
updated by a DOM mutation (element insertion), and it fails because
there is no logic of updating the CSS target element at element
insertion time.

The reason of passing the test is that the assertions pass
unintentionally when the parsing is finished while waiting for
requestAnimationFrame() since the CSS target element is updated after
the parsing is finished.

The spec mentions that the CSS target element for each document is
updated while navigating, but it is unclear that the target element
can be lively updated by any DOM mutation.

  • html.spec.whatwg.org/multipage/browsing-the-web.html#scroll-to-fragid

Bug: 1349538
Change-Id: Ifbaceb342bfaf6034acf3dbc453c23422d582a3e

Reviewed-on: https://chromium-review.googlesource.com/3822442
WPT-Export-Revision: cc6a10b6142191942dd03fb5cc32ac4f18e3fabb

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce587825f603 [wpt PR 35415] - Fix flaky wpt test: css/selectors/invalidation/target-pseudo-in-has.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ce587825f603

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.