Closed Bug 1784055 Opened 2 years ago Closed 2 years ago

Loading spinner and text is displayed when the user has Sync turned OFF

Categories

(Firefox :: Firefox View, defect, P1)

Firefox 105
defect
Points:
3

Tracking

()

VERIFIED FIXED
105 Branch
Tracking Status
firefox105 --- verified

People

(Reporter: boltean, Assigned: sclements)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(3 files)

Affected versions:
Nightly 105.0a1 (2022-08-09)

Affected platforms:
Windows 10 64-bit

Preconditions:
The user is already logged in to the browser with a Fx account.
The user has gone through the connect another device flow.

Steps to reproduce:

  1. Go to about:preferences#sync page and click the "Change" button under Syncing options.
  2. Click the "Disconnect..." button and in the modal click "Disconnect" again.
  3. Click the "Firefox View" icon and observe the message displayed.

Actual result:
The "Sit tight while your tabs sync. It'll be just a moment." message is displayed with a loading wheel.

Expected result:
The "Turn on syncing to continue" message is displayed with "Turn on sync in settings" button.

Whiteboard: [fidefe-2022-mr1-firefox-view]
Priority: -- → P1
Assignee: nobody → sclements
Status: NEW → ASSIGNED

So, this is kinda interesting... The disconnect sync button per the STR, ends up calling Weave.Service.StartOver() per here: https://searchfox.org/mozilla-central/source/browser/base/content/browser-sync.js#1790

And that looks like it deletes user data but doesn't change the "identity.fxaccounts.enabled" and "services.sync.engine.tabs" prefs (the latter part explains why it gets stuck on the loading spinner). But because FX view finds out about this via the "weave:service:start-over" observer in SyncedTabs.jsm, which also resets the lastTabFetch pref, it think it just needs another tab refresh and gets stuck there.

If you then click on "Turn on syncing" in the same place you disconnect it, a weave login notification triggers a UIState update and then shows most recent tabs (so it doesn't at least delete any tab data).

So I'll add that archived error state and have the button do the same thing the "Turn on syncing" button does (not show the third card in the setup flow to re-enable the pref, since that isn't the thing that was changed).

Points: --- → 3
  • Add new error state strings and logic
  • Add new test case
Summary: Wrong message displayed when the user has Sync turned OFF → Loading spinner and text is displayed when the user has Sync turned OFF
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20d523a8aeb3
Add error state for when sync is disconnected r=sfoster,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

Hello,
This is verified as fixed using Firefox nightly 105.0a1 (2022-08-22) and FxA stage while on Windows 10 64-bit. The "Turn on syncing to continue" message is displayed with the "Turn on sync in settings" button.
See the attached screen record.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: