1784117 - Expand Nimbus targeting in background tasks

Status: RESOLVED FIXED

(Toolkit :: Background Tasks, defect, P1)

Description

[Nick Alexander :nalexander [he/him]]

In Bug 1776514, I took some effort to allow targeting in background tasks based on a snapshot of the default profile's targeting state. However, similar to Bug 1782136, I didn't appreciate that we need to impact the Nimbus level and not just the Firefox Messaging Experiment System level. This ticket tracks lifting the defaultProfile targeting to Nimbus itself, and not just to the Messaging System.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1776514

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1784117 - Pre: Fix typoes. r?barret

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1784117 - Lift default profile targeting to Nimbus in background tasks. r?barret

This was oversight. In background tasks, I took some care to provide
the snapshot of the default profile's targeting state to the Firefox
Messaging System, but it also needs to be provided to Nimbus to filter
experiments directly.

For expedience, I provide an extra targeting context object to
ExperimentManager.onStartup.

The targeting contexts for Nimbus proper and Firefox Messaging System
are somewhat independent; that's why the triggering context remains in
the invocation of sendTriggerMessage.

Depends on D154308

Comment 4

[Dianna Smith [:diannaS]]

As a reminder today is the last beta before RC week If this is required for 104.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3114e1fa806c
Pre: Fix typoes. r=barret,application-update-reviewers,bytesized
https://hg.mozilla.org/integration/autoland/rev/27f856541c9f
Lift default profile targeting to Nimbus in background tasks. r=barret

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Dianna Smith [:diannaS] from comment #4)

As a reminder today is the last beta before RC week If this is required for 104.

Thanks for the heads up, but it's fine for this to ride with 105.

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3114e1fa806c
https://hg.mozilla.org/mozilla-central/rev/27f856541c9f