Closed Bug 1784129 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35423 - Fix canvas createpattern for null and broken images.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35423 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35423
Details from upstream follow.

Aaron Krajeski <aaronhk@chromium.org> wrote:

Fix canvas createpattern for null and broken images.

According to the WHATWG spec, we should be returning null (and not throwing an error) when calling createPattern on images with bad usability.

https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-createpattern

This allows these tests to pass.

Bug: 1230183, 1055111
Change-Id: I44d7bc52992f12bbe8e045b5866b4f24058da6e2

Reviewed-on: https://chromium-review.googlesource.com/3708127
WPT-Export-Revision: 6771de128b8d766796c37ad25153504c9a2626dc

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 6 subtests

Status Summary

Firefox

OK : 7
PASS : 136
FAIL : 11
TIMEOUT: 1
ERROR : 1
NOTRUN : 5

Chrome

OK : 7
PASS : 142
FAIL : 6
TIMEOUT: 1
ERROR : 1
NOTRUN : 4

Safari

OK : 7
PASS : 98
FAIL : 49
TIMEOUT: 1
ERROR : 1
NOTRUN : 5

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /content-index/content-index.https.window.html [wpt.fyi]
    • The Content Index API is exposed: FAIL (Chrome: PASS, Safari: FAIL)
    • index.add parameters are validated.: FAIL (Chrome: PASS, Safari: FAIL)
    • index.getAll returns the same objects provided.: FAIL (Chrome: PASS, Safari: FAIL)
    • index.add with same ID overwrites existing entry.: FAIL (Chrome: PASS, Safari: FAIL)
    • index.delete removes entry.: FAIL (Chrome: PASS, Safari: FAIL)
    • index.delete works on invalid ID.: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html [wpt.fyi]
    • createImageBitmap with CanvasRenderingContext2D image source.: FAIL (Chrome: PASS, Safari: PASS)
  • /html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html [wpt.fyi]
    • picture: source (max-width:500px) broken image, img broken image, resize to wide: FAIL (Chrome: FAIL, Safari: FAIL)
    • picture: source (max-width:500px) valid image, img broken image, resize to wide: FAIL (Chrome: FAIL, Safari: FAIL)
    • picture: source (max-width:500px) broken image, img broken image, resize to narrow: FAIL (Chrome: FAIL, Safari: FAIL)
    • picture: source (max-width:500px) broken image, img valid image, resize to narrow: FAIL (Chrome: FAIL, Safari: FAIL)
  • /shape-detection/detection-security-test.https.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
    • Face - detect(broken image): TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
    • Barcode - detect(broken image): NOTRUN (Chrome: TIMEOUT, Safari: NOTRUN)
    • Text - detect(broken image): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Face - detect(broken video): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Barcode - detect(broken video): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
    • Text - detect(broken video): NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8252ce922d22 [wpt PR 35423] - Fix canvas createpattern for null and broken images., a=testonly

https://hg.mozilla.org/mozilla-central/rev/8252ce922d22

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.