1784191 - Perma clang-trunk security/nss/lib/base/error.c:91:65: error: incompatible function pointer types passing 'FARPROC' (aka 'int (*)() __attribute__((stdcall))') to parameter of type 'PRThreadPrivateDTOR' (aka 'void (*)(void *)') [-Wincompatible-function-poi

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Mike Hommey [:glandium]]

This affects mingw clang builds with clang trunk

[task 2022-08-11T01:43:38.919Z] 01:43:38    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/base/error.c:91:65: error: incompatible function pointer types passing 'FARPROC' (aka 'int (*)() __attribute__((stdcall))') to parameter of type 'PRThreadPrivateDTOR' (aka 'void (*)(void *)') [-Wincompatible-function-pointer-types]
[task 2022-08-11T01:43:38.920Z] 01:43:38     INFO -              return PR_NewThreadPrivateIndex(&error_stack_index, freePtr);
[task 2022-08-11T01:43:38.920Z] 01:43:38     INFO -                                                                  ^~~~~~~
[task 2022-08-11T01:43:38.920Z] 01:43:38     INFO -  /builds/worker/workspace/obj-build/dist/include/nspr/prthread.h:192:44: note: passing argument to parameter 'destructor' here
[task 2022-08-11T01:43:38.921Z] 01:43:38     INFO -      PRUintn *newIndex, PRThreadPrivateDTOR destructor);
[task 2022-08-11T01:43:38.921Z] 01:43:38     INFO -                                             ^
[task 2022-08-11T01:43:38.922Z] 01:43:38     INFO -  1 error generated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1784191 - Cast the result of GetProcAddress.

clang trunk recently added a check for incompatible function pointers,
and now is not happy with a FARPROC being given as a
PRThreadPrivateDTOR, because that's not the same signature. But FARPROC
is the "normal" return type from GetProcAddress, but OTOH, it's not the
actual type signature for PR_Free.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Mike Hommey [:glandium]]

Fixed by the import in bug 1785784