1784268 - Import the GC spec tests

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Ryan Hunt [:rhunt]]

The GC proposal has spec-tests for its instructions [1]. At some point we should import them using our tool [2].

[1] https://github.com/WebAssembly/gc/tree/main/test/core/gc
[2] https://searchfox.org/mozilla-central/source/js/src/jit-test/etc/wasm/generate-spectests

Comment 1

[Ben Visness [:bvisness]]

Attachment: WIP: Bug 1784268: Import wasm gc spec tests.

Comment 2

[Ben Visness [:bvisness]]

The attached patch is not final but can be used to run spec tests. They don't all pass yet, but we can create new bugs for issues that come up and make them block this bug until they're all resolved.

Comment 3

[Ben Visness [:bvisness]]

Attachment: Bug 1784268: Fix small issues blocking GC spec tests. r=rhunt

• Fix wasm module serialization order. Element segments sometimes need to refer to types during deserialization, but element segments were being deserialized before code objects (which contain types).
• Do function subtype checks on import, rather than requiring strict equality.
• Allow explicit null function references in table initializers.
• Initialize type defs before tables when instantiating modules.

Comment 4

[Ben Visness [:bvisness]]

Attachment: Bug 1784268: Import wasm gc spec tests. r=rhunt

This required significantly reworking how the harness handles ref.extern. We no
longer "canonicalize" externrefs created by the harness, since when checking for
an externref result we now extract the numeric value contained within.

Depends on D188737

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bd8ba854c67
Fix small issues blocking GC spec tests. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/49e126195a99
Import wasm gc spec tests. r=rhunt

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7bd8ba854c67
https://hg.mozilla.org/mozilla-central/rev/49e126195a99