1784286 - Add renderer time probe for frames with no shader compilation

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Bas Schouten (:bas.schouten)]

While investigating slow renderer times, Nicolas and I discovered that at the start of a session under circumstances where the shader cache is flushed, we can end up with a bunch of very slow frames due to shader compilation. We want to know if this also explains the slow frames in our telemetry, to that end we're adding a probe that records only frames during which no shader building took place.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1784286: Add telemetry probe for measuring rendering time for frames without shader compilation. r=nical

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Data Review

Comment 3

[Chris H-C :chutten]

Comment on attachment 9289478 [details]
Data Review

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Bas Schouten and gfx-telemetry-alerts are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/524ef2de255e
Add telemetry probe for measuring rendering time for frames without shader compilation. r=nical

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing webrender bustages.

• backout: https://hg.mozilla.org/integration/autoland/rev/b50437218a0d735732c48c016ca46cce91645ae6
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=524ef2de255ef216908c5468a522a46310df4ae5&group_state=expanded
• failure log:
  • error on gfx/wr/webrender/src/renderer/mod.rs:1525:12

[task 2022-08-16T20:02:32.511Z] error: unnecessary parentheses around `if` condition
[task 2022-08-16T20:02:32.512Z]     --> webrender/src/renderer/mod.rs:1525:12
[task 2022-08-16T20:02:32.512Z]      |
[task 2022-08-16T20:02:32.512Z] 1525 |         if (self.profile.get(profiler::SHADER_BUILD_TIME).is_none()) {
[task 2022-08-16T20:02:32.512Z]      |            ^                                                       ^
[task 2022-08-16T20:02:32.512Z]      |
[task 2022-08-16T20:02:32.512Z]      = note: `-D unused-parens` implied by `-D warnings`
[task 2022-08-16T20:02:32.512Z] help: remove these parentheses
[task 2022-08-16T20:02:32.512Z]      |
[task 2022-08-16T20:02:32.513Z] 1525 -         if (self.profile.get(profiler::SHADER_BUILD_TIME).is_none()) {
[task 2022-08-16T20:02:32.513Z] 1525 +         if self.profile.get(profiler::SHADER_BUILD_TIME).is_none() {
[task 2022-08-16T20:02:32.513Z]      |
[task 2022-08-16T20:02:32.513Z] 
[task 2022-08-16T20:02:43.453Z] error: could not compile `webrender` due to previous error

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9db221adc938
Add telemetry probe for measuring rendering time for frames without shader compilation. r=nical

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9db221adc938