1784323 - "Confirm before closing multiple tabs" asks for confirmation when closing a window with just Firefox View and one tab

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

STR:

1. Enable the "Confirm before closing multiple tabs" setting in about:preferences.
2. Open a new window. It should have two tabs: the Firefox View tab and the newtab tab.
3. Close the window (using the Ctrl+W keyboard shortcut or clicking the X window button).
4. The window closes as expected.
5. Open another new window. It should have two tabs: the Firefox View tab and the newtab tab.
6. Switch focus from the newtab tab to the Firefox View tab.
7. [2022-09-21 EDIT] To reproduce this bug, I now have to switch focus from Firefox View back to the newtab tab.
8. Try to close the window (using the Ctrl+W keyboard shortcut or clicking the X window button).

Expected result:

The window should close without interruption. The Firefox View tab should not be considered a "blocking tab" for closing a window.

Actual result

Firefox shows the "Confirm before closing multiple tabs" dialog. See the attached screenshot.

Comment 1

[Bernard Igiri]

Attachment: Bug 1784323 - Prevent hidden Firefox View tab from triggering the closing multiple tabs warning r=Dao!

Explicitly exclude the Firefox View tab, from the tab count, when determining whether or not to show the multiple open tabs warning.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14e2cb36d7b8
Prevent hidden Firefox View tab from triggering the closing multiple tabs warning r=dao,Gijs

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14e2cb36d7b8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bigiri, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Bernard Igiri]

Comment on attachment 9295860 [details]
Bug 1784323 - Prevent hidden Firefox View tab from triggering the closing multiple tabs warning r=Dao!

Beta/Release Uplift Approval Request

• User impact if declined: When the user closes the browser they may get unexpected "confirm before closing multiple tabs" prompts.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR:

1. Enable the "Confirm before closing multiple tabs" setting in about:preferences.
2. Open a new window. It should have two tabs: the Firefox View tab and the newtab tab.
3. Close the window (using the Ctrl+W keyboard shortcut or clicking the X window button).
4. The window closes as expected.
5. Open another new window. It should have two tabs: the Firefox View tab and the newtab tab.
6. Switch focus from the newtab tab to the Firefox View tab.
7. [2022-09-21 EDIT] To reproduce this bug, I now have to switch focus from Firefox View back to the newtab tab.
8. Try to close the window (using the Ctrl+W keyboard shortcut or clicking the X window button).

Expected result:

The window should close without interruption. The Firefox View tab should not be considered a "blocking tab" for closing a window.

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): There is an automated test in place but this does have functionality change. The risk is that the "confirm before closing multiple tabs" prompt may show or not show at the wrong time.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9295860 [details]
Bug 1784323 - Prevent hidden Firefox View tab from triggering the closing multiple tabs warning r=Dao!

We ship 106 tomorrow.

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue described in comment 0 using an old Nightly from 2022-08-11, verified that this is not reproducible anymore using Nightly 107.0a1 from today across platforms (Windows 10, macOS 11 and Ubuntu 22.04).

Comment 9

[Bogdan Maris, Desktop Test Engineering]

Based on the recent change in the firefox status flags, I'll go ahead and close this bug as Verified Fixed.