Open Bug 1784385 Opened 2 years ago Updated 2 years ago

WR performance - Remove unused GLSL code for get_image_quad_uv and associated perspective interpolation

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

ASSIGNED

People

(Reporter: ahale, Assigned: ahale)

References

(Blocks 1 open bug)

Details

WebRender used to use inverse transforms in GLSL shaders that sampled from render targets, this code is no longer used but is a performance burden and maintenance burden, it makes the GLSL shader code non-trivially more complex without a benefit since it is unused now.

This also causes a surprising and undocumented breakage in reftests when using static images to test shaders meant to be used with a render target, because static images do not fill in this transform information in GpuCache, resulting in broken rendering if this code is not commented out (ran into this when working on bug 1671784).

Since this code is not used anymore, it should be removed to clean up the codebase.

It's not known how much performance benefit would come from removing this code in the shaders, but probably something (it incurs a per vertex cost and per pixel cost).

Severity: -- → S3
Type: task → defect
Component: Graphics → Graphics: WebRender
Summary: Remove unused GLSL code for get_image_quad_uv and associated perspective interpolation → WR performance - Remove unused GLSL code for get_image_quad_uv and associated perspective interpolation
Blocks: 1784386
You need to log in before you can comment on or make changes to this bug.