1784453 - Prefer GLES by default on ARM

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Robert Mader [:rmader]]

On most ARM devices the integrated GPUs and their drivers are usually better optimized for GLES than desktop GL. Thus lets prefer GLES on ARM builds, potentially reducing bug and improving performance.

In case of v3d this is also needed to turn on HW-WR by default as we disable it due to the first default GL context not supporting GL/GLES >= 3.0.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Robert Mader [:rmader]]

Attachment: Bug 1784453 - Prefer GLES by default on Linux-ARM, r=#gfx-reviewers

On most ARM devices the integrated GPUs and their drivers are
usually better optimized for GLES than desktop GL. Thus lets
prefer GLES on ARM builds, potentially reducing bug and improving
performance.

In case of v3d this is also needed to turn on HW-WR by default
as we disable it due to the first default GL context not supporting
GL >= 3.0.

Notes:

• Unfortunately we can't straightly use StaticPrefs in glxtest
• We need to ask for a 2.x context as GLES defaults to 1.x. Asking
  for 2.x should, however, should give us a 3.x/4.x one if supported.

Comment 3

[Robert Mader [:rmader]]

https://treeherder.mozilla.org/jobs?repo=try&revision=1fdfa85c1e97c35979ecdf5497366a004e0f1739

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb15320dee97
Prefer GLES by default on Linux-ARM, r=gfx-reviewers,nical

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/bb15320dee97

Comment 6

[Robert Mader [:rmader]]

This didn't work as planned - _ARM64_ is apparently Windows only 🤦

Comment 7

[Robert Mader [:rmader]]

https://treeherder.mozilla.org/jobs?repo=try&revision=082eb6c39f76313c1622164b3b6aabc0817ce47e

Comment 8

[Robert Mader [:rmader]]

https://treeherder.mozilla.org/jobs?repo=try&revision=d7a2a020e8a1812dd6587c3ee6ad2d554e3cb15f

Comment 9

[Robert Mader [:rmader]]

Attachment: Bug 1784453 - Use correct compiler macro for ARM builds, r=#gfx-reviewers

_ARM64_ appears to be a Windows-only thing.

Fixes D154506

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51722c5665a0
Use correct compiler macro for ARM builds,

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/51722c5665a0