1784481 - Implement ScriptLoaderInterface for Workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, task)

Description

[Yulia Startsev [:yulia]]

The WorkerScriptLoader now roughly adheres to the same structure as the DOM Script Loader. There are still significant differences: It is still recreated for every importScripts call, meaning that a single worker will have multiple, nested, workerScriptLoaders.

However, we can start sharing code. This change will have WorkerScriptLoader implement the ScriptLoaderInterface, allowing us to plug in the ModuleLoader code.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1784481 - Implement ScriptLoaderInterface Skeleton in WorkerScriptLoader; r=jonco

This introduces the basic skeleton to make WorkerScriptLoader a ScriptLoaderInterface.
ScriptLoaderInterface defines the methods that are shared between any given ScriptLoader (for
example the DOM script loader, the ComponentScriptLoader) and the ModuleLoader for a particular
component.

This patch also adds documentation to make the role and responsibilities of the
ScriptLoaderInterface clear.

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1784481 - Use ScriptLoaderInterface methods for reporting errors; r=jonco

Fill out the ReportErrorToConsole method, and add documentation for ReportWarningToConsole

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1784481 - Use ScriptLoaderInterface method for filling compile options; r=jonco

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae19d0d9ad84
Implement ScriptLoaderInterface Skeleton in WorkerScriptLoader; r=jonco
https://hg.mozilla.org/integration/autoland/rev/9d91e7bba726
Use ScriptLoaderInterface methods for reporting errors; r=jonco
https://hg.mozilla.org/integration/autoland/rev/8d35cee853a5
Use ScriptLoaderInterface method for filling compile options; r=jonco

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ae19d0d9ad84
https://hg.mozilla.org/mozilla-central/rev/9d91e7bba726
https://hg.mozilla.org/mozilla-central/rev/8d35cee853a5