1784486 - [wpt-sync] Sync PR 35451 - Don't lay out OOFs inside fragmentation if side-effects are disabled.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35451 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35451
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Don't lay out OOFs inside fragmentation if side-effects are disabled.

The OOF positioning code depends on the LayoutBox data being up-to-date,
which doesn't happen if we lay out with side-effects disabled (as that
would be side-effect).

Just don't lay them out. It's not safe.

This also reverts CL:3823699, as it should now be obsolete with this
brutal fix.

Bug: 1347713
Change-Id: Icb63237618647489159446a50d8eb7984243a7f9
Reviewed-on: https://chromium-review.googlesource.com/3829547
WPT-Export-Revision: 548162a7654b3fdd00b32161eb53718286ac3742

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f1ed0199617e2493dce6dd13970ce3382af7779

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f3cb69e30e7
[wpt PR 35451] - Don't lay out OOFs inside fragmentation if side-effects are disabled., a=testonly

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6f3cb69e30e7