1784532 - Remove current_session usage from log.entryAdded tests

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Now that we have support for script.evaluate and script.callFunction the fallback to WebDriver classic's execute_script is no longer necessary. As such the following listed items can be removed:

https://searchfox.org/mozilla-central/search?q=execute_script&path=testing%2Fweb-platform%2Ftests%2Fwebdriver%2Ftests%2Fbidi%2Flog%2F&case=false&regexp=false

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

To help the Chrome team in getting these tests to run as well I'm going to fix that as a Friday evening patch.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1784532 - [wdspec] Remove usage of current_session from log.entryAdded tests.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I would propose to add this bug to the script evaluate feature of M4 with probably 2 points.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

My changes also include the removal of current_session.new_window(), so expanding the scope to all the usages of current_session for log.entryAdded tests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5accd30736c0
[wdspec] Remove usage of current_session from log.entryAdded tests. r=webdriver-reviewers,Sasha,jdescottes

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35513 for changes under testing/web-platform/tests

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5accd30736c0

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[sadym]

FWIW: current_time uses WebDriver Classic current_session.execute_script("return Date.now();")

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Interesting. It's indirectly using current_session and as such didn't fully match this bug's scope.

@sadym, would you mind creating an upstream pull request to get this usage removed?

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

FYI Maxim is taking care of it over on https://github.com/web-platform-tests/wpt/pull/35577.