Remove current_session usage from log.entryAdded tests
Categories
(Testing :: geckodriver, task, P1)
Tracking
(firefox105 fixed)
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
()
Details
(Whiteboard: [webdriver:m4], [wptsync upstream])
Attachments
(1 file)
Now that we have support for script.evaluate and script.callFunction the fallback to WebDriver classic's execute_script is no longer necessary. As such the following listed items can be removed:
|
Assignee | |
Comment 1•2 years ago
|
||
To help the Chrome team in getting these tests to run as well I'm going to fix that as a Friday evening patch.
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
I would propose to add this bug to the script evaluate feature of M4 with probably 2 points.
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
My changes also include the removal of current_session.new_window(), so expanding the scope to all the usages of current_session for log.entryAdded tests.
|
||
Updated•2 years ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5accd30736c0 [wdspec] Remove usage of current_session from log.entryAdded tests. r=webdriver-reviewers,Sasha,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35513 for changes under testing/web-platform/tests
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
|
||
Comment 10•2 years ago
|
||
FWIW: current_time uses WebDriver Classic current_session.execute_script("return Date.now();")
|
|
Assignee | |
Comment 11•2 years ago
|
||
Interesting. It's indirectly using current_session and as such didn't fully match this bug's scope.
@sadym, would you mind creating an upstream pull request to get this usage removed?
|
|
Assignee | |
Comment 12•2 years ago
•
|
||
FYI Maxim is taking care of it over on https://github.com/web-platform-tests/wpt/pull/35577.
Description
•