1784578 - [wpt-sync] Sync PR 35460 - Move the pop-up "show" event earlier and make it cancelable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35460 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35460
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Move the pop-up "show" event earlier and make it cancelable

Per [1], there's a desire from Mozilla to move the show event
earlier in the process, and make it cancelable. I see no issues
with doing that, so pending a discussion (at [1]), I'm going to
make this change.

[1] https://github.com/openui/open-ui/issues/579

Bug: 1307772
Change-Id: I87fcec84146f99434bb88d2af12941a2c9156586
Reviewed-on: https://chromium-review.googlesource.com/3826329
WPT-Export-Revision: 6308fbd43dd28b984f6936cc234821e33e3a329d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=890d09a9d6c274df6c3e519e5c689481bbe8c0c9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=df161b739fef5cff72d8642649fb5e4a7f99e571

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
PASS: 1
FAIL: 1

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/popups/popup-events.tentative.html [wpt.fyi]
  • Show and hide events get properly dispatched for popups: FAIL (Chrome: PASS, Safari: FAIL)
  • Show event is cancelable: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ccd1bd1efc
[wpt PR 35460] - Move the pop-up "show" event earlier and make it cancelable, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8892b0e477c4
[wpt PR 35460] - Update wpt metadata, a=testonly

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/63ccd1bd1efc
https://hg.mozilla.org/mozilla-central/rev/8892b0e477c4