Closed Bug 1784698 Opened 6 months ago Closed 6 months ago

httpserver's test_default_index_handler.js doesn't run all its tests due to an undefined variable

Categories

(Core :: Networking, defect, P2)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1784698 - test_default_index_handler.js fails to run all intended tests due to undefined variable. r?#necko-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Although test_default_index_handler.js passes, it doesn't run all of its tests due to an undefined variable, top.

ESLint doesn't currently pick up on this, as our configuration makes it think that top is a global variable.

The test doesn't fail, as there is no catch handler for handling the stop request part of it.

Blocks: 1784699

test_default_index_handler.js is failing to check the pathQueryRef is valid, because 'top' is undefined. Unfortunately the test
harness doesn't catch the error, and so this wasn't found earlier. This fixes the harness as well as the test.

Depends on D154591

Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e930e8660e99
test_default_index_handler.js fails to run all intended tests due to undefined variable. r=necko-reviewers,valentin

https://hg.mozilla.org/mozilla-central/rev/e930e8660e99

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.