Closed
Bug 1784698
Opened 2 years ago
Closed 2 years ago
httpserver's test_default_index_handler.js doesn't run all its tests due to an undefined variable
Categories
(Core :: Networking, defect, P2)
Core
Networking
Tracking
()
RESOLVED
FIXED
105 Branch
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
Although test_default_index_handler.js passes, it doesn't run all of its tests due to an undefined variable, top.
ESLint doesn't currently pick up on this, as our configuration makes it think that top is a global variable.
The test doesn't fail, as there is no catch handler for handling the stop request part of it.
|
Assignee | |
Comment 1•2 years ago
|
||
test_default_index_handler.js is failing to check the pathQueryRef is valid, because 'top' is undefined. Unfortunately the test
harness doesn't catch the error, and so this wasn't found earlier. This fixes the harness as well as the test.
Depends on D154591
|
||
Updated•2 years ago
|
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e930e8660e99 test_default_index_handler.js fails to run all intended tests due to undefined variable. r=necko-reviewers,valentin
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•