1784840 - Convert Backgroundtasks_purgeHTTPCache.jsm to ESM

Status: RESOLVED FIXED

(Core :: Networking: Cache, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

./mach esmify should do most of the work

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Snagging this one as a good first bug for some students that are starting with us from CalState in a few days.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Note that I'm working on a thing that will most possibly use this task. Hopefully I won't add any big change to the task itself but just saying.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

If that's the case, let me release it then - I don't want the student onboarding to be on the critical path of anything.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1784840 - Convert all background tasks to ESM r=nalexander

BackgroundTaskManager still uses ChromeUtils.import instead of importESModule since the latter does not expose the error code for NS_ERROR_FILE_NOT_FOUND case: https://searchfox.org/mozilla-central/rev/31368c7795f44b7a15531d6c5e52dc97f82cf2d5/js/xpconnect/loader/mozJSModuleLoader.cpp#1529-1534

Depends on D156941

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bc135513e52
Convert all background tasks to ESM r=nalexander,application-update-reviewers,necko-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9bc135513e52

Comment 7

[Andrej (:aglavic)]

== Change summary for alert #35710 (as of Thu, 20 Oct 2022 20:57:30 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
14%	tresize	windows10-64-shippable-qr	e10s fission stylo webrender-sw	7.08 -> 6.05
6%	tsvgr_opacity	windows10-64-shippable-qr	e10s fission stylo webrender-sw	70.25 -> 65.92
6%	tsvg_static	windows10-64-shippable-qr	e10s fission stylo webrender-sw	52.69 -> 49.46
4%	tsvgr_opacity	windows10-64-shippable-qr	e10s fission stylo webrender-sw	68.58 -> 65.99

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35710

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

I doubt this has anything to do with WebRender and SVG rendering, I think it should go to something in Graphics component. Any idea why the alert came here instead?