Closed Bug 1784998 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 35480 - Change pop-up light dismiss trigger from mousedown to mouseup

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(5 files)

Notable wpt changes
136.82 KB, text/plain
Details
Notable wpt changes
136.82 KB, text/plain
Details
Notable wpt changes
159.08 KB, text/plain
Details
Notable wpt changes
159.08 KB, text/plain
Details
Notable wpt changes
159.08 KB, text/plain
Details

Sync web-platform-tests PR 35480 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35480
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Change pop-up light dismiss trigger from mousedown to mouseup

Per the resolution [1], it is better for users to trigger light-
dismiss on mouseup rather than mousedown, because it makes it less
likely that an accidental mouse-down will cause a pop-up to hide,
possibly losing state.

[1] https://github.com/openui/open-ui/issues/529#issuecomment-1205605282

Bug: 1307772
Change-Id: Ib6b3ab633cecc4e051bbfc7857c4177c14e2419e
Reviewed-on: https://chromium-review.googlesource.com/3830822
WPT-Export-Revision: 52e51758400652746dd2c9ffbbbe74c0d5393fa3

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI Total 2 tests and 24 subtests ## Status Summary ### Firefox `OK` : 1 `FAIL` : 1418[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 1420[GitHub] `ERROR`: 1 ### Chrome `OK` : 2 `PASS` : 1420 `FAIL` : 2 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cadbbafa4571f92f8643391c4a5804bacce14aa) [GitHub PR Head](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI Total 2 tests and 24 subtests ## Status Summary ### Firefox `OK` : 1 `FAIL` : 1418[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 1420[GitHub] `ERROR`: 1 ### Chrome `OK` : 2 `PASS` : 1420 `FAIL` : 2 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cadbbafa4571f92f8643391c4a5804bacce14aa) [GitHub PR Head](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 2 tests and 24 subtests ## Status Summary ### Firefox `OK` : 1 `FAIL` : 1418[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 1420[GitHub] `ERROR`: 1 ### Chrome `OK` : 2 `PASS` : 1420 `FAIL` : 2 ### Safari `OK` : 1 `FAIL` : 1420 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cadbbafa4571f92f8643391c4a5804bacce14aa) [GitHub PR Head](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 2 tests and 24 subtests ## Status Summary ### Firefox `OK` : 1 `FAIL` : 1418[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 1420[GitHub] `ERROR`: 1 ### Chrome `OK` : 2 `PASS` : 1420 `FAIL` : 2 ### Safari `OK` : 1 `FAIL` : 1420 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cadbbafa4571f92f8643391c4a5804bacce14aa) [GitHub PR Head](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 2 tests and 24 subtests ## Status Summary ### Firefox `OK` : 1 `FAIL` : 1418[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 1420[GitHub] `ERROR`: 1 ### Chrome `OK` : 2 `PASS` : 1420 `FAIL` : 2 ### Safari `OK` : 1 `FAIL` : 1420 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cadbbafa4571f92f8643391c4a5804bacce14aa) [GitHub PR Head](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=3e49ce9406900b7a6952bf08becb9fb2987f7842&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/476b2582e4c3 [wpt PR 35480] - Change pop-up light dismiss trigger from mousedown to mouseup, a=testonly https://hg.mozilla.org/integration/autoland/rev/f61855c9dcca [wpt PR 35480] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/476b2582e4c3
https://hg.mozilla.org/mozilla-central/rev/f61855c9dcca

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: