1785003 - resource leak in nsImapMailFolder::CompactAll

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Magnus Melin [:mkmelin]]

*** CID 1507881: Resource leaks (RESOURCE_LEAK)
/comm/mailnews/imap/src/nsImapMailFolder.cpp: 1420 in nsImapMailFolder::CompactAll(nsIUrlListener *, nsIMsgWindow *)()
1414 rv = imapFolder->Expunge(l, aMsgWindow);
1415 if (NS_FAILED(rv)) {
1416 // Make sure expungeCount is kept in sync!
1417 l->OnStopRunningUrl(nullptr, rv);
1418 }
1419 }

CID 1507881:  Resource leaks  (RESOURCE_LEAK)
Variable "l" going out of scope leaks the storage it points to.

1420 } else {
1421 // No expunging. Start the compaction immediately.
1422 doCompact();
1423 }
1424
1425 return NS_OK;

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1785003 - Fix resource leak in nsImapMailFolder::CompactAll. r=benc

Comment 2

[Ben Campbell]

Ahh... I think that's the static analysis not realising the listener if refcounted by the compact operations - it'll be destroyed automagically when the last compact finishes. It would be a leak if the folder list was empty. There's a check for that no-folders case, but I think your fix adding an extra explicit refptr is definitely the right way to go - thanks for that!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/723c4ec60cc9
Fix resource leak in nsImapMailFolder::CompactAll. r=benc