1785007 - (stop-editor-declaring-friends) Split editor classes for outer and inner one from point of view of the editor module

Status: NEW

(Core :: DOM: Editor, enhancement, P4)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, EditorBase, TextEditor and HTMLEditor declares public methods only for outer users of the editor module, e.g., DOM and layout. For helper classes in the editor module, they register a lot of friend classes like:

• https://searchfox.org/mozilla-central/rev/e84464e810c868a6be2e2beb4405db75b14ac7d9/editor/libeditor/EditorBase.h#2869-2904
• https://searchfox.org/mozilla-central/rev/e84464e810c868a6be2e2beb4405db75b14ac7d9/editor/libeditor/TextEditor.h#572-574
• https://searchfox.org/mozilla-central/rev/e84464e810c868a6be2e2beb4405db75b14ac7d9/editor/libeditor/HTMLEditor.h#4521-4572

Therefore, the member scope of editor classes do not work actually. This is too bad especially for new contributors. Currently I'm thinking that we should keep EditorBase, TextEditor and HTMLEditor classes as public methods in the tree. Then, we should make them has new classes which are copies of current those classes, perhaps, new name should be EditorBaseCore, TextEditorCore and HTMLEditorCore or something. Then, they can set their member scopes properly, and we can stop exposing editor local headers such as EditorUtils.h, HTMLEditHelpers.h, etc which are required to declare the editor classes.