1785125 - Disable OPFS in Private Browsing mode

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

Required to enable/go to release.

Eventually we'd like to support OPFS in PB mode, but it would require either in-ram storage (not a good idea), or encryption with unsaved keys (like we're working on for PB support for IndexedDB/etc)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1785125: Disable OriginPrivateFileSystem (OPFS) in Private Browsing r=#dom-storage-reviewers,asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af22df1c53c2
Disable OriginPrivateFileSystem (OPFS) in Private Browsing r=asuth,dom-storage-reviewers,janv

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing Bp-hybrid bustages on FileSystemManagerParentFactory.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/fs/parent/FileSystemManagerParentFactory.cpp:48:16: error: incomplete type 'mozilla::OriginAttributes' named in nested name specifier

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12f5f2d2aac9
Disable OriginPrivateFileSystem (OPFS) in Private Browsing r=asuth,dom-storage-reviewers,janv

Comment 5

[Marian-Vasile Laza]

Backed out changeset 12f5f2d2aac9 (Bug 1785125) for causing mochitest failures on test_basics.html.
Backout link
Push with failures <--> 13
Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be010fc803d9
Disable OriginPrivateFileSystem (OPFS) in Private Browsing r=asuth,dom-storage-reviewers,janv

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing bp-hybrid bustages on FileSystemManager.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/fs/api/FileSystemManager.cpp:67:28: error: possible misuse of comma operator here [-Werror,-Wcomma]

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9c663333d4f
Disable OriginPrivateFileSystem (OPFS) in Private Browsing r=asuth,dom-storage-reviewers,janv

Comment 9

[Serban Stanca [:SerbanS]]

Backed out for causing bp-hybrid bustages on FileSystemManager.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/fs/parent/FileSystemManagerParentFactory.cpp:40:16: error: incomplete type 'mozilla::OriginAttributes' named in nested name specifier

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3fca4d9c7f7
Disable OriginPrivateFileSystem (OPFS) in Private Browsing r=asuth,dom-storage-reviewers,janv

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e3fca4d9c7f7