1785159 - [wpt-sync] Sync PR 35493 - Replace requestIdleCallback with double-rAF in wpt/accessibility tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35493 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35493
Details from upstream follow.

Scott Haseley <[e-mail]> wrote:

Replace requestIdleCallback with double-rAF in wpt/accessibility tests

Two accessibility/crashtests are flaky because requestIdleCallback
requires threaded compositor mode in Blink to work properly. This CL
fixes the flakes by replacing requestIdleCallback with a double-
requestAnimationFrame, which runs the class resetting code after the
main contents has been rendered. This pattern is used by other
accessibility crashtests, e.g. slot-assignment-lockup.html.

Alternatively we could run these tests in the virtutal/threaded test
suite, but changing the tests seems reasonable since there's a precedent
for double-rAF pattern and requestIdleCallback isn't supported yet in
WebKit.

Bug: 1353428
Change-Id: I51497f7f93bf43cbc4e25fb28179e579bd98dc29

Reviewed-on: https://chromium-review.googlesource.com/3834842
WPT-Export-Revision: c0112b948cb4dc881ddb777fb1382c8b8c1e266a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=914a4481a5536d5062b08605d2fb06cf73c2eb39

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89fcfab49674
[wpt PR 35493] - Replace requestIdleCallback with double-rAF in wpt/accessibility tests, a=testonly

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/89fcfab49674