1785201 - JavaScript error: chrome://remote/content/shared/TabManager.jsm, line 311: TypeError: can't access property "linkedBrowser", tab is undefined

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Seen for the intermittent failure on bug 1785171:

https://treeherder.mozilla.org/logviewer?job_id=387565753&repo=mozilla-central&lineNumber=1918-1924

[task 2022-08-17T00:18:09.462Z] 00:18:09     INFO - TEST-START | /css/css-multicol/column-balancing-paged-001-print.html
[task 2022-08-17T00:18:09.473Z] 00:18:09     INFO - Setting pref dom.animations-api.compositing.enabled to true
[task 2022-08-17T00:18:09.484Z] 00:18:09     INFO - Setting pref layout.css.cascade-layers.enabled to true
[task 2022-08-17T00:18:09.546Z] 00:18:09     INFO - PID 8436 | 1660695489545	Marionette	INFO	Testing http://web-platform.test:8000/css/css-multicol/column-balancing-paged-001-print.html == http://web-platform.test:8000/css/css-multicol/column-balancing-paged-001-print-ref.html
[task 2022-08-17T00:18:09.551Z] 00:18:09     INFO - PID 8436 | JavaScript error: chrome://remote/content/shared/TabManager.jsm, line 311: TypeError: can't access property "linkedBrowser", tab is undefined
[task 2022-08-17T00:18:34.463Z] 00:18:34     INFO - Got timeout in harness
[task 2022-08-17T00:18:34.466Z] 00:18:34     INFO - TEST-UNEXPECTED-TIMEOUT | /css/css-multicol/column-balancing-paged-001-print.html | TestRunner hit external timeout (this may indicate a hang)

Some callee of _getWindowForTab() (addTab, selectTab or remoteTab) is passing undefined as tab. As such it might be good to have a check that the tab is valid.

Comment 1

[Intermittent Failures Robot]

1 failures in 2449 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1785201&startday=2022-10-03&endday=2022-10-09&tree=all

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that this failure can actually be seen a lot of times in any Wr log even if the job passes:
https://firefoxci.taskcluster-artifacts.net/AYh84TEDT2Spl9ZPT43NzQ/0/public/logs/live_backing.log

Here an except from a trace log:

mach wpt --setpref="remote.log.level=Trace" testing/web-platform/tests/animation-worklet/worklet-animation-cancel.https.html

 0:14.50 pid:34864 1669148199644	Marionette	DEBUG	Starting load of http://web-platform.test:8000/animation-worklet/references/not-translated-box-ref.html
 0:14.51 pid:34864 JavaScript error: chrome://remote/content/shared/TabManager.sys.mjs, line 331: TypeError: can't access property "linkedBrowser", tab is undefined
 0:14.51 pid:34864 1669148199650	Marionette	TRACE	[13] Reftest actor created for window id 28
 0:14.52 pid:34864 1669148199658	Marionette	TRACE	[13] Reftest actor created for window id 8589934593

The actual stack of the failure is the following:

 0:12.97 pid:36666 _getWindowForTab@chrome://remote/content/shared/TabManager.sys.mjs:335:15
 0:12.97 pid:36666 selectTab@chrome://remote/content/shared/TabManager.sys.mjs:313:30
 0:12.97 pid:36666 switchToTab@chrome://remote/content/marionette/browser.sys.mjs:309:29
 0:12.97 pid:36666 register@chrome://remote/content/marionette/browser.sys.mjs:335:12
 0:12.97 pid:36666 GeckoDriver.prototype.registerBrowser@chrome://remote/content/marionette/driver.sys.mjs:383:21
 0:12.97 pid:36666 GeckoDriver.prototype.setWindowHandle@chrome://remote/content/marionette/driver.sys.mjs:1265:12
 0:12.97 pid:36666 ensureWindow@chrome://remote/content/marionette/reftest.sys.mjs:167:23

So it fails when we are trying to focus the tab after switching to it:
https://searchfox.org/mozilla-central/rev/650c19c96529eb28d081062c1ca274bc50ef3635/remote/marionette/browser.sys.mjs#302-310

And here is the problem. For reftests we only have a faked win.gBrowser that doesn't contain actual tabs. It means we cannot switch to any tab and should return early similar to when no gBrowser is available.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1785201 - [marionette] Don't select the tab when switching to a reftest window.

Comment 4

[Marco Mucci [:MarcoM]]

Hi Henrik. Can you assign points.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f38f2ad982d
[marionette] Don't select the tab when switching to a reftest window. r=webdriver-reviewers,jdescottes

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3f38f2ad982d

Comment 8

[Intermittent Failures Robot]

1 failures in 3206 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-ccov-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1785201&startday=2023-04-10&endday=2023-04-16&tree=all