Open Bug 1785266 Opened 2 years ago Updated 7 months ago

Spawn independant WindowGlobalTarget actors in the Browser Toolbox

Categories

(DevTools :: Framework, enhancement)

enhancement

Tracking

(Not tracked)

People

(Reporter: ochameau, Unassigned)

References

(Depends on 1 open bug, Blocks 4 open bugs)

Details

Attachments

(2 files)

For now, the browser toolbox spawns a unique ParentProcessTargetActor for the whole parent process resources. We don't spawn any WindowGlobalTargetActor in the parent process other than this one (parent process target actor inherits from WindowGlobalTargetActor).

This is somewhat similar with content processes and ContentProcessTargetActor.
But here, we do spawn independant WindowGlobalTargetActor, one per WindowGlobal.
This is mostly special around Thread actor and Sources. We only attach the thread actor of the ContentProcessTargetActor and retrieve all the sources, including the one related to WindowGlobals via the ContentProcessTargetActor.

This breaks EFT/EveryFrameTarget principles and makes it harder to understand and maintain our codebase. Because of this, the debugger isn't seeing the same targets as the iframe dropdown or webconsole's context selector.

Blocks: 1741927
Depends on: 1786467
Blocks: 1637785
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: