1785274 - Firefox View - Logo and page title shouldn't be inside <nav> as there's no navigation; make logo presentational

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P3)

Description

[Ray Fambro]

Firefox View includes a Fx logo but it’s not announced to a user. It could be exposed to assistive technology as one element (logo and text) as Firefox View logo

Comment 1

[:Gijs (he/him)]

How strongly do we feel this should be announced? I would have expected that just switching to the FxView tab would cause the screenreader/AT to announce/expose the page title, which is also "Firefox View". The logo is decorative and announcing "Firefox View" a second time seems superfluous. But perhaps I'm missing something about how this works?

Comment 2

[Morgan Reschenberg [:morgan]]

Not strongly :) I'd mark it as presentational (seems like it might already be?), unless it's also clickable/does something.
It looks like this logo and the accompanying page title text are wrapped in a nav element, which is a bit misleading to screen reader users because it indicates that the items in that nav are interactive and perform navigation actions. It doesn't seem like that's the case, unless I'm missing something. I think we should leave the page title text ("Firefox View") but remove the nav structure and have the img be presentational.

Comment 3

[:Gijs (he/him)]

That all makes sense to me. Morphing this bug accordingly.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Sam Foster [:sfoster] (he/him)]

Yeah this is fair. I made it <nav> as the longer-term intention for this column looked like it would be used for navigational buttons/icons like the same region in about:addons. But as of right now, there's no navigational options in there so it doesnt make sense.

Comment 6

[Bernard Igiri]

Attachment: Bug 1785274 - Changed container of Fx View logo and title to a non-navigational tag r=sclements!

Replaced tag containing Fx View logo and title with a non-navigational tag, so that screen readers do not announce it as a navigational element.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1594c5adde76
Changed container of Fx View logo and title to a non-navigational tag r=sclements

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1594c5adde76

Comment 9

[:Gijs (he/him)]

Comment on attachment 9294524 [details]
Bug 1785274 - Changed container of Fx View logo and title to a non-navigational tag r=sclements!

Beta/Release Uplift Approval Request

• User impact if declined: Confusing screenreader information presented to users
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Use NVDA or another screenreader and check how it presents the Firefox logo and wordmark on the top left of the page
• List of other uplifts needed: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial markup change in the Firefox View page
• String changes made/needed: No
• Is Android affected?: No

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9294524 [details]
Bug 1785274 - Changed container of Fx View logo and title to a non-navigational tag r=sclements!

Approved for 106.0b4, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/2add1185023c

Comment 12

[Bogdan Maris, Desktop Test Engineering]

Reproduced the issue using old Nightly from 2022-09-15, verified that using latest Nightly 107.0a1 and Firefox 106.0b4 on Windows 10 (NVDA) and macOS 11 (VoiceOver), the logo is not called out and Firefox View title is called as a simple text not as a nav.