1785293 - Screenshots component should respect "Always ask you where to save files"

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P2)

Description

[Niklas Baumgardner [:niklas]]

The component currently doesn't respect the value of "Always ask you where to save files" in settings. We should open the downloads panel if it is checked

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c0eb6e89712
Downloading screenshot respects 'Always ask you where to save files'. r=sfoster

Comment 5

[Marian-Vasile Laza]

Backed out changeset 7c0eb6e89712 (Bug 1785293) for causing bc failures on browser_screenshots_test_downloads.js.
Backout link
Push with failures <--> bc1
Failure Log
Also bc4 Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fdf3fc76d06
Downloading screenshot respects 'Always ask you where to save files'. r=sfoster

Comment 7

[Marian-Vasile Laza]

Backed out changeset 1fdf3fc76d06 (Bug 1785293) for causing bc failures on browser_screenshots_drag_test.js.
Backout link
Push with failures <--> bc1
Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b080b41aecf4
Downloading screenshot respects 'Always ask you where to save files'. r=sfoster

Comment 9

[Serban Stanca [:SerbanS]]

Backed out for causing bc failures on browser_screenshots_test_escape.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_test_escape.js | Test timed out -

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fb3e9d1f9e1
Downloading screenshot respects 'Always ask you where to save files'. r=sfoster

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3fb3e9d1f9e1

Comment 12

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that the issue is fixed with firefox 123.0a1(2023-12-22) and 109.0.1 on Ubuntu 22.04, Windows 11 and MacOS 12.6. I will update the status of this issue and the flags.

Have a nice day!