Closed Bug 1785418 Opened 2 years ago Closed 4 months ago

Intermittent /webrtc/RTCDTMFSender-ontonechange.https.html | single tracking bug

Categories

(Core :: WebRTC, defect, P2)

Product:
Core
Component:
WebRTC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
124 Branch
Tracking Flags:
Tracking Status
firefox124 --- fixed

People

(Reporter: jmaher, Assigned: pehrsons)

References

Details

(Keywords: intermittent-failure, intermittent-testcase)

Attachments

(3 files)

Bug 1785418 - Allow RTCDTMFToneChangeEvents to fire up to 1ms early. r?bwc!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1785418 - Update wpt expectations. r?bwc!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1785418 - Update wpt expectations that are obsolete since fixing bug 1742831. r?bwc!
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Additional information about this bug failures and frequency patterns can be found by running: ./mach test-info failure-report --bug 1785418

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=427709816&repo=mozilla-central

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.

Status: REOPENED → RESOLVED
Closed: 10 months ago → 8 months ago
Resolution: --- → INCOMPLETE

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=436176079&repo=autoland

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Failure data here is

apehrson@apehrson-42624 m-c-2 % ./mach test-info failure-report --bug 1785418

Querying data for bug [1785418, 1723244, 1779709] annotated from 2024-01-15 to 2024-02-14 on trunk.


1 errors with:
00:22:18     INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCDTMFSender-ontonechange.https.html | insertDTMF() with duration less than 40 should be clamped to 40 - assert_between_inclusive: Expect tonechange event for "B" to be fired approximately after 110 milliseconds expected a number greater than or equal to 110 and less than or equal to 4110 but got 109
... no failure lines recorded in https://treeherder.mozilla.org/intermittent-failures ...
  macosx1015-64-shippable-qr/opt-web-platform-tests: 1

2 errors with:
... no failure lines recorded in https://treeherder.mozilla.org/intermittent-failures ...
  windows11-32-2009-shippable-qr/opt-web-platform-tests: 1
  windows11-32-2009-qr/opt-web-platform-tests: 1

1 errors with:
01:16:32     INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCDTMFSender-ontonechange.https.html | Calling insertDTMF() multiple times in the middle of tonechange events should cause future tonechanges to be updated the last provided tones - assert_between_inclusive: Expect tonechange event for "3" to be fired approximately after 340 milliseconds expected a number greater than or equal to 340 and less than or equal to 4340 but got 339
... no failure lines recorded in https://treeherder.mozilla.org/intermittent-failures ...
  windows11-64-2009-shippable-qr/opt-web-platform-tests: 1

1 errors with:
03:19:42     INFO - TEST-UNEXPECTED-FAIL | /webrtc/RTCDTMFSender-ontonechange.https.html | insertDTMF() with interToneGap less than 30 should be clamped to 30 - assert_between_inclusive: Expect tonechange event for "" to be fired approximately after 390 milliseconds expected a number greater than or equal to 390 and less than or equal to 4390 but got 389
... no failure lines recorded in https://treeherder.mozilla.org/intermittent-failures ...
  windows11-32-2009-qr/opt-web-platform-tests: 1

This is simple; nsTimer can fire early, and the test is very generous with how timers fire, but only if they fire late. We can allow them to fire 1ms early.

Assignee: nobody → apehrson
Priority: P3 → P2

Firefox's timer implementation allows events to fire 250μs early. Instead of
using a non-fuzzy timer in Firefox (may cause extra wakeups) or an artificial
extra delay on every dtmf event, relax the test case a bit.

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8175af8c6fb4
Allow RTCDTMFToneChangeEvents to fire up to 1ms early. r=bwc
https://hg.mozilla.org/integration/autoland/rev/1221c36a2774
Update wpt expectations. r=bwc
https://hg.mozilla.org/integration/autoland/rev/786036d00de2
Update wpt expectations that are obsolete since fixing bug 1742831. r=bwc
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44593 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/8175af8c6fb4
https://hg.mozilla.org/mozilla-central/rev/1221c36a2774
https://hg.mozilla.org/mozilla-central/rev/786036d00de2

Status: REOPENED → RESOLVED
Closed: 8 months ago → 4 months ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: