Closed
Bug 1785745
Opened 2 years ago
Closed 2 years ago
Clean up JITFrameInfo and UniqueStacks classes
Categories
(Core :: Gecko Profiler, task, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(2 files)
A few small chances, to make them more classes than structs, in particular to ensure that operations on their data are controlled.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
This makes it easier to understand how these are actually used, and constrain
these uses as intended.
Depends on D154958
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69a99aa23502
Convert struct JITFrameInfo into a proper class - r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/c56cab09ccce
Make UniqueStack::mUniqueStrings and mCodeAddressService private - r=canaltinova
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/69a99aa23502
https://hg.mozilla.org/mozilla-central/rev/c56cab09ccce
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•